From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbcF1O2f (ORCPT ); Tue, 28 Jun 2016 10:28:35 -0400 Received: from foss.arm.com ([217.140.101.70]:47888 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbcF1O2e (ORCPT ); Tue, 28 Jun 2016 10:28:34 -0400 Date: Tue, 28 Jun 2016 15:17:55 +0100 From: Catalin Marinas To: Will Deacon Cc: Suzuki K Poulose , mark.rutland@arm.com, steve.capper@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs Message-ID: <20160628141755.GE4585@e104818-lin.cambridge.arm.com> References: <1466507556-9027-1-git-send-email-suzuki.poulose@arm.com> <20160628110621.GC5425@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160628110621.GC5425@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 12:06:22PM +0100, Will Deacon wrote: > On Tue, Jun 21, 2016 at 12:12:36PM +0100, Suzuki K Poulose wrote: > > +static struct attribute_group cpuregs_attr_group = { > > + .attrs = cpuregs_attrs, > > + .name = "identification" > > +}; > > This makes sense because MIDR/REVIDR belong to the "Identification" > functional group of registers, however I wonder if we should put this > under a directory called "regs" or similar, so that we don't have a > confusing top-level directory where "identification" lives alongside > things like "hotplug" and "cpuidle". IMO, there are too many subdirectories and I don't think we would expose any other registers than the ID ones. -- Catalin