From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbcF1TSC (ORCPT ); Tue, 28 Jun 2016 15:18:02 -0400 Received: from smtprelay0060.hostedemail.com ([216.40.44.60]:54876 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752574AbcF1TSA (ORCPT ); Tue, 28 Jun 2016 15:18:00 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4605:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12291:12517:12519:12663:12683:12740:13069:13161:13229:13311:13357:13439:14096:14097:14181:14659:14721:21063:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: team25_4595c64063b16 X-Filterd-Recvd-Size: 1927 Date: Tue, 28 Jun 2016 15:17:56 -0400 From: Steven Rostedt To: Petr Mladek Cc: Ingo Molnar , Frederic Weisbecker , Masami Hiramatsu , Jiri Kosina , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes Message-ID: <20160628151756.5ff5b24f@gandalf.local.home> In-Reply-To: <1467035677-12193-1-git-send-email-pmladek@suse.com> References: <1467035677-12193-1-git-send-email-pmladek@suse.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2016 15:54:33 +0200 Petr Mladek wrote: > 1st patch adds one more paranoid check of the modified function on x86. > > Plus there are 3 small changes that appeared when hunting down > the 1st patch. > > Petr Mladek (4): > ftrace/x86: Make sure to modify 5-bite instructions > ftrace/x86: Do not crash when reading wrong ftrace func The first two are mostly just "detect error, when it happens again" chanes. > ftrace: Always destroy trampoline when shutting down the trace > ftrace: Fixup trace_selftest_ops() These two seem to fix real bugs. I'm thinking they should go in now and be backported via stable. Thoughts? -- Steve > > arch/x86/kernel/ftrace.c | 12 ++++++++- > kernel/trace/ftrace.c | 62 ++++++++++++++++++++++--------------------- > kernel/trace/trace_selftest.c | 7 ++--- > 3 files changed, 47 insertions(+), 34 deletions(-) >