From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbcF1RcN (ORCPT ); Tue, 28 Jun 2016 13:32:13 -0400 Received: from mail-by2on0070.outbound.protection.outlook.com ([207.46.100.70]:60975 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751952AbcF1RcL (ORCPT ); Tue, 28 Jun 2016 13:32:11 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Tue, 28 Jun 2016 20:26:38 +0300 From: Yury Norov To: Joseph Myers CC: , , , , , , , , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 10/23] [AARCH64] Detect ILP32 in configure scripts. Message-ID: <20160628171320.GA1670@yury-N73SV> References: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com> <1467131978-669-11-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: VI1PR07CA0099.eurprd07.prod.outlook.com (10.165.229.153) To CY1PR07MB2248.namprd07.prod.outlook.com (10.164.112.150) X-MS-Office365-Filtering-Correlation-Id: 13e3334a-11be-49dd-3dd6-08d39f79faad X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;2:siuwiHCpjl3NycHWTA4WzXr1labXyOhzVGeRhfYy+6Oj3MSaSMl8UAyhRf8CmCTE8Nmz06T4d2LsKoq813ltJw0OpkDY73SLuyZbh6o2KKdb6iEBr9BbygHErL5OrtIKH04LLwP/WrLDK8A7yWXxDGywCT0YHDL5NA7sxLabnFtSr3+zWRGJEPtHRM0e2QqX;3:L3/UKJHH3dmAW/yDrIr5Dd/plQTHLj1QCKhwbumwEnmfNzRr8eDBNwIKdeXfv3ydi2Mn1dmWgQJ48apHedmlNfzsVAKTVcUlMEAd0V6AheeZCnFvqG52Vntb9uD7NGVL;25:CeR8hO+l0K7JFs3Va7xhiav56x80/S6R2cXdDrMOVFGSMBG/hOHfI7fBWxOPwsCcUmCGyMjHpAg/10cjxBrJoMf1irIwARatO3jDW7+Jzjf0fbaagrdgv1dtCHWmXVL5JSB/BO6y9SFTiv5KgNOLYvab++QtCeacSjLfcsjVG5y/a63QtSm4Z1I5Ow2skqv4ljbZi1pzzE8ysgXJW1j1UAEBPsBsZmCJZj0af1UUvj21Ji0EIV7IEUD8fiQlkuh2kPPbtk2b2xzfnBxeJJLymiE5WYVyovid0R3IlAQfdmdaWuMrXdsK2V71VA00NMs5RPx3pFV1/mUbFgdREdnTY3yGtRo6Zw+M4BZUBv1rCE5TiIcIFQPUyoOck8j+jAiMujzy8I1RNCzLciTRcNJ3Ag05APoLeGaT6vk7IZhZt+0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;20:s3nNynfZztc+PJIJXyYRg0eW7GN9MtkP5n8Ga1naDRi5LSPBjhKlCjhnYwtdvMTBGw47Z3fu5KlQUYAiGugW1Zw1Yq229/cz1+0iKhlUbQXGOtR0CuxIzuYk0FIl/vA8qWGkAkldG398lerdroZHPTfiD3kZ2f1ZHl41v1CukZpju+fSBhbvf3hnV/7scwHmHeXxXUkOJCJUOC2v0tOxduSl7Gt+TcmIC6pFEfQ+HxBmhVQHPEF73yagMZj6FCh6fXs/yBZSrNO2DpAmIWqDi+9KuZXsLtHhfeTf8UzBH6rSd6pKA2NC8oXEdii7qkwq6p49WAkwI38vBNe2RM2WRvWV/+PMANG9/GMqpCDaZTuq7/mjfAWe6M5wm6EMEGbBuKXgXMbig1VmD1FbuDKGTG1A8K1PfXKaNFiTRcJMjRmkCGzSBViNTHvVf4wOcj+kiaW0s2ftg0fldaoJ6GtfB5owAZKxLCgfElGh1zt5ehD0saaeDBvGTRV968Q1Ybv+MCp503I4tej0wmWkURV5I/Q0XvbvUBnC7b+F4nnqH8L3ZmzLFwUfgOGPZw9Ehgj3cjhfeMngiJ57hlFs4fN8IV+Q5/j1OnqjSPToquuQQsg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CY1PR07MB2248;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;4:a94vWs4LeSAzzeuGokLpH7sXnKzN+KNAO0jXujWnPBDbmMKKIFtOWgcULXzyWKoNV4eDrqTUGkLxub70DdPi+sAdWdj+/Ex+jkHxqYWvnoWTjwj7nr03iqnF0IXnS6J2v9PB2Mi0t6V9SEY4NmAYQDQXlQJtv2APLzx8n8aZOvGeC6nH6Ho9nuUiHjelYg0iu3FEKZ1qBoHG+Q5vf0ajNlYWKN+vPBkzMDCMLG6ta2tCa6jInN32zkhn1mH41bRwgsZIrm9V9gPvk9+uNqrlpuVBRORurEthv7kqglX93KZR+048fU0mCigf3vGCj/Waq21hVcINE6j7aC9o4cDKXshTj7E2DhFebheeDQxRCLlqaOzXHr058wsqx/CY2Ue/ X-Forefront-PRVS: 0987ACA2E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(189002)(54534003)(199003)(24454002)(50466002)(46406003)(54356999)(76176999)(6116002)(4326007)(23726003)(3846002)(586003)(50986999)(1076002)(101416001)(19580395003)(105586002)(2906002)(83506001)(97756001)(42186005)(33656002)(7846002)(7736002)(110136002)(81156014)(81166006)(8676002)(4001430100002)(4001350100001)(305945005)(68736007)(97736004)(9686002)(33716001)(76506005)(189998001)(15975445007)(2950100001)(77096005)(106356001)(66066001)(47776003)(92566002)(107886002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2248;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2248;23:kacK+UIN6WiXabVpEZxn8I3n/jZCzjVZ9mzGAwZPj?= =?us-ascii?Q?b3gKYrOO1bQDATD/OhpraQ4NSUURmNqMTSG6rjG7nCoRCwVT+gsMuH8/OqZO?= =?us-ascii?Q?mgMUyyi1p9F39U5Wx9v0mrnssfLI3Y+wVAlMyDsjIBAjRjJsxjK99PhuX0GP?= =?us-ascii?Q?hsbXeoUCRxZuliDWo6iBaTVPPHuQyBfVPQyKHVAQ3heEWDsCdA7r9LAe1ZDh?= =?us-ascii?Q?Xngo4R/6x47w3UGnwN/5x1KLNbTqh9QVQ7Fjv9kDoDV4HZMmX/VIsALx0QG9?= =?us-ascii?Q?uNh7920y3FEw/KLiZwb39OaPUlJFo2pGVxI4s16Fe/HCch+HH5YCAf/WU6lZ?= =?us-ascii?Q?byj5ZfkgOp6fRYFGhxMwKPk/wi629igU4TM+bAEzw6desxSEjO+xMrtxbcEQ?= =?us-ascii?Q?dafLn7UB84hZnkgkZG6r+juG2CK3ppL1/n+zKlJfjjAZ+3Mhf4fOsBFzI11m?= =?us-ascii?Q?AezYRTJ2UNvvdzKKxJYQFQhtW5hWM/tMM6OrGb0w5j9IJd2SGN7U1QvcpaXh?= =?us-ascii?Q?O9eyb5vDMXHWegtyJhJuC/Xx2gDGIKyxZm+dk8ouoLLxrIei9IVH6kVGD5AO?= =?us-ascii?Q?Ytg0SJuVVm5dDJO7zctdaPSTBqhbHgi3vyAa9XDvHzEMRupVbfChHj+jYEUi?= =?us-ascii?Q?Wt3zcclBkBuPnqs04YWJ/GrdeqKggbzWjIyC4FVOT4F8UdfhDaCpPUNTvaeA?= =?us-ascii?Q?Slybe5Q1ABCj8QkZPP/iGCCLy3NxsX2ds6QqBojxcYrGVH1hP1Qbjt/8lM1C?= =?us-ascii?Q?jU3M/kHm5vhtVE/FthuKC5uedBJa4ZWlFHNsx6IMO1WSw84T0Dy+8evjUa+y?= =?us-ascii?Q?jEBgoqNUhtYnAHHbNpnRwl/0wvTwEPbdr9VUp0oikn3se1svEdc6Zs6IpnWF?= =?us-ascii?Q?UmHMPZ3mAz/khjgjH0p2yiQ0tv7Nv3GvJf1gUXz2HfWHmtxWgb93G4yuegcC?= =?us-ascii?Q?bQEp7LTxQDY8XsjMTRbfNKsAbsmnN2+XZIMca5JjzOCC5p901P0bPV1j0gj9?= =?us-ascii?Q?SYSmOvySSt8Mz3x4dx/ET5O/NWJeEr3vL6vq6hAP2xtoEIaWqgDUKcTOenAM?= =?us-ascii?Q?q4zz5qLUFzedkUZMJkr0P4Ow0CViNrto20vBcxrSXznV1mOfRi8+m69V6mqF?= =?us-ascii?Q?oGpbTSiJQuJ1skduPc8Y6Y+VFzXU+CFGwNJT2ZJaQZfJFR4fSTEflrdm6N4e?= =?us-ascii?Q?FfJz17xeYNF5tgVOSnO4mgqx0cbxFR+5aVjsqCP7A37p9nGev4UHZEwAdYNh?= =?us-ascii?Q?qTQSrKVLutWwCcsS0k=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;6:OmPAsV/mJ5PFZTO4hMk/Mi9ZcZfz9F+dO913jQHsOYumOUvxerdWRMRwvCaYmrNiBwr5ImtnimYKb1z8VPrDtRi0KreXjAxXGxDbop+NzWgEicKnxVWhi/TMu33qsU0nwN7J8gEm7dwOQbCTxafO3mTGMNntuHZZRRiXt8SLZoNr24v1OI96qAmdZZjTC5u53ZsVlt3STQ47lUPSSjiIZlfKNUmbaps0PmqdRJgsw1MyN4OwiQRzHlzUIQOZDb+57Xa79BgnIZQGcoPHV9WGvSWvqw08oLZp5WNlWR0ij0wS5Psb1O9DbSNQLCbeAyqc;5:DP+g8YSPfc4QkPlFav5NefSg5KrrGJBr3TKOjfwqk6Uvz3f2RAA+KjjckU9H0ZYlAQ7u5p1Dk4ltYx94Kky9BE7AemVQa6KIGg3WzRtWR4RYdqd3LAlGi7ZVJyF/7ZF++7iqjtC/8N/Io3myWuGJew==;24:31dgc41uMmEFiWgt1MG2djwWOuOEjiCxG4znfm1hIPQkF/WbPQEYMTGWG0fq2/lou57gJx2MZ8KDapS3iKLUOnhda+8O1u9UwPNvUXQv3eE=;7:U8H6ARVtq67l1m3VHfJroJ/S12e1ijVfQNfeKJXj3Q5F7eYQcc9Xaw/g4SJoO+zTsK70ks8FriiwBD4hzI9+7wZiej51gL1RkQL3a0Fuc9vnD7rOEy2BJyh+pjkn64roj6cDHSpoWwJRp6426OXjTnxCJEqghIG5FFoCGe6c0nRVXEkyrJPSD12wcTp7Wg2RvmFbt+PKeo17WfOeA3pnndrkKlQiHZEOc3B7pVKCIptTIQ9LQBI6Xx799pwqrARcWCt3oy0E/qzSVju4spN5bw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2016 17:31:03.0435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2248 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 05:07:49PM +0000, Joseph Myers wrote: > and > still apply. > Please make the changes requested there before any reposting of the patch > series. Yes, I forgot about glibc version. I don't want to add changelogs because I think patches order should/may be changed, and as all that changelogs touch single file, there will be nightmare to rebase series. >> diff --git a/sysdeps/aarch64/preconfigure >> b/sysdeps/aarch64/preconfigure >> index d9bd1f8..4bcd8e3 100644 >> --- a/sysdeps/aarch64/preconfigure >> +++ b/sysdeps/aarch64/preconfigure >> @@ -1,6 +1,15 @@ >> case "$machine" in >> aarch64*) >> base_machine=aarch64 >> - machine=aarch64 >> + case "$CC $CFLAGS $CPPFLAGS " in >> + *" -mabi=ilp32 "*) aarch64_config_abi=ilp32 ;; >> + *" -mabi=lp64 "*) aarch64_config_abi=lp64 ;; >> + *) aarch64_config_abi=default ;; >> + esac >> + case $aarch64_config_abi in >> + default) machine=aarch64/lp64 aarch64_config_abi=lp64 >> ;; > > It would seem better to test how the compiler behaves (what it > predefines), as now done for MIPS, so that this works with a compiler > configured --with-abi=ilp32 without needing to add an explicit ABI > option > to CC or CFLAGS. I didn't understand what you mean here and forgot to ask. I didn't work much on glibc, and not familiar to it's build system. Could you explain it little more detailed please?