From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbcF1WIL (ORCPT ); Tue, 28 Jun 2016 18:08:11 -0400 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:42280 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752449AbcF1WIE (ORCPT ); Tue, 28 Jun 2016 18:08:04 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21434,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: print54_4eccdea7cdb19 X-Filterd-Recvd-Size: 2150 Date: Tue, 28 Jun 2016 18:05:40 -0400 From: Steven Rostedt To: Rasmus Villemoes Cc: Jiri Olsa , Lai Jiangshan , lkml , Frederic Weisbecker Subject: Re: [RFC/PATCH] lib/vsprintf: Add support to store cpumask Message-ID: <20160628180540.5da4405e@gandalf.local.home> In-Reply-To: <87mvm5gezg.fsf@rasmusvillemoes.dk> References: <1467128075-10841-1-git-send-email-jolsa@kernel.org> <20160628122608.0ea291b2@gandalf.local.home> <878txpi066.fsf@rasmusvillemoes.dk> <20160628155614.1cad283a@gandalf.local.home> <87mvm5gezg.fsf@rasmusvillemoes.dk> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016 23:50:27 +0200 Rasmus Villemoes wrote: > On Tue, Jun 28 2016, Steven Rostedt wrote: > > > But people don't usually run "make smatch" on debug kernels. > > trace_printk() currently is not allowed to be used in the kernel. When > > it is used, a big ugly banner is posted on boot up saying that the > > kernel is in "debug mode" and is "unstable" (even though it isn't) just > > to scare people enough to never compile with a trace_printk() in their > > code. If they need a permanent trace_printk() then they need to use > > tracepoints. > > But don't tracepoints also pass through vbin_printf? IOW, are there no > print-like function calls in the kernel where a static checker warning > for %pX would be worthwhile? tracepoints don't use vbin_printf() but you are right, they do save the data in binary format parse them out later. Perhaps we should set up something in the static checker to test for this in TP_printk() within the TRACE_EVENT() macros. -- Steve