From: Mark Brown <broonie@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: boris.brezillon@free-electrons.com, lee.jones@linaro.org,
briannorris@chromium.org, linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode
Date: Tue, 28 Jun 2016 19:52:44 +0100 [thread overview]
Message-ID: <20160628185244.GT17217@sirena.org.uk> (raw)
In-Reply-To: <1467089591-7631-1-git-send-email-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Mon, Jun 27, 2016 at 09:53:11PM -0700, Douglas Anderson wrote:
> Note also that the upper bound of usleep_range probably shouldn't be a
> full 1 ms longer than the lower bound since I've seen plenty of hardware
> with a ramp rate of ~5000 uS / uV and for small jumps the total delays
> are in the tens of uS. 1000 is way too much. We'll try to be dynamic
> and use 10%
Surely the upper bound here is just an upper bound and we're essentially
just saying that "anything over minimum is fine" here? Though now I
look at the implementation it seems it's doing something entirely
unehelpful and actually trying to delay for the longest possible time
which doesn't seem like what we want or what the usleep_range() API
would suggest :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-28 18:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 4:53 Douglas Anderson
2016-06-28 10:32 ` Caesar Wang
2016-06-28 16:07 ` Brian Norris
2016-06-28 18:52 ` Mark Brown [this message]
2016-06-28 19:31 ` Doug Anderson
2016-06-28 19:53 ` Mark Brown
2016-06-28 18:56 ` Mark Brown
2016-06-28 19:35 ` Doug Anderson
2016-07-01 8:06 ` Mark Brown
2016-07-01 20:17 ` Doug Anderson
2016-07-02 7:59 ` Mark Brown
2016-07-06 18:30 ` Doug Anderson
2016-07-07 8:17 ` Mark Brown
2016-07-02 15:47 ` Boris Brezillon
2016-07-04 8:53 ` Mark Brown
2016-07-04 9:05 ` Boris Brezillon
2016-07-04 9:13 ` Mark Brown
2016-07-08 16:41 ` Thierry Reding
2016-07-06 12:27 ` Boris Brezillon
2016-07-06 18:31 ` Doug Anderson
2016-07-07 8:16 ` Mark Brown
2016-07-07 8:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628185244.GT17217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®