mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Azael Avalos <coproscefalo@gmail.com>
To: Darren Hart <dvhart@infradead.org>,
	Jonathan Cameron <jic23@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Azael Avalos <coproscefalo@gmail.com>
Subject: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA
Date: Tue, 28 Jun 2016 13:58:55 -0600	[thread overview]
Message-ID: <20160628195855.22199-1-coproscefalo@gmail.com> (raw)

The toshiba_acpi driver added support to the accelerometer axis
via the IIO subsystem, but failed to add the dependency to the
Kconfig file, making the driver fail to compile if the IIO
subsystem is not selected.

This patch adds a depedency to the IIO subsystem to the
ACPI_TOSHIBA entry in Kconfig to avoid such build failure.

Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
Darren, Jonathan:
 I just received a few mails from the kbuild test robot informing
 the build failure, as a fix for this I just added a hard dependency
 to IIO, but maybe Jonathan can weigh in and provide me with a better
 alternative (perhaps some ifdefs) as to the hard IIO dependency.

 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index c06bb85..633fc5c 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -669,6 +669,7 @@ config ACPI_TOSHIBA
 	depends on SERIO_I8042 || SERIO_I8042 = n
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
 	depends on RFKILL || RFKILL = n
+	depends on IIO
 	select INPUT_POLLDEV
 	select INPUT_SPARSEKMAP
 	---help---
-- 
2.8.4

             reply	other threads:[~2016-06-28 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 19:58 Azael Avalos [this message]
2016-06-29  5:16 ` Darren Hart
2016-06-29  5:21   ` Azael Avalos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628195855.22199-1-coproscefalo@gmail.com \
    --to=coproscefalo@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®