From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbcF2JMQ (ORCPT ); Wed, 29 Jun 2016 05:12:16 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39379 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbcF2JMO (ORCPT ); Wed, 29 Jun 2016 05:12:14 -0400 Date: Wed, 29 Jun 2016 05:11:42 -0400 (EDT) Message-Id: <20160629.051142.259737654994822294.davem@davemloft.net> To: Yisen.Zhuang@huawei.com Cc: salil.mehta@huawei.com, yankejian@huawei.com, liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de, andriy.shevchenko@linux.intel.com, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Subject: Re: [PATCH net-next 9/9] net: hns: get reset registers from DT From: David Miller In-Reply-To: <1467021255-95900-10-git-send-email-Yisen.Zhuang@huawei.com> References: <1467021255-95900-1-git-send-email-Yisen.Zhuang@huawei.com> <1467021255-95900-10-git-send-email-Yisen.Zhuang@huawei.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jun 2016 02:12:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yisen Zhuang Date: Mon, 27 Jun 2016 17:54:15 +0800 > @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus) > return -ENODEV; > } > > + sc_reg = &mdio_dev->sc_reg; > /* 1. reset req, and read reset st check */ > - ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1, > - MDIO_SC_RESET_ST, 0x1, > + ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1, > + sc_reg->mdio_reset_st, 0x1, > MDIO_CHECK_SET_ST); > if (ret) { > dev_err(&bus->dev, "MDIO reset fail\n"); What in the world are you doing to the indentation here? Please read your patches before actually sending them, such things will be quite obvious by simple visual inspection.