From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751945AbcF2Jsf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2016 05:48:35 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:39586 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750932AbcF2Jsd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2016 05:48:33 -0400
Date: Wed, 29 Jun 2016 05:48:01 -0400 (EDT)
Message-Id: <20160629.054801.713412217544385924.davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: Dept-GELinuxNICDev@qlogic.com, sony.chacko@qlogic.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [patch] qlcnic: use the correct ring in
 qlcnic_83xx_process_rcv_ring_diag()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20160627205029.GA22095@mwanda>
References: <20160627205029.GA22095@mwanda>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jun 2016 02:48:33 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Jun 2016 23:50:29 +0300

> There is a static checker warning here "warn: mask and shift to zero"
> and the code sets "ring" to zero every time.  From looking at how
> QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
> qlcnic_83xx_hndl() should be removed.
> 
> Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.