From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbcF2IWx (ORCPT ); Wed, 29 Jun 2016 04:22:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:60938 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbcF2IWv (ORCPT ); Wed, 29 Jun 2016 04:22:51 -0400 Date: Wed, 29 Jun 2016 10:22:49 +0200 From: Petr Mladek To: Steven Rostedt Cc: Ingo Molnar , Frederic Weisbecker , Masami Hiramatsu , Jiri Kosina , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes Message-ID: <20160629082249.GB3238@pathway.suse.cz> References: <1467035677-12193-1-git-send-email-pmladek@suse.com> <20160628151756.5ff5b24f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160628151756.5ff5b24f@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2016-06-28 15:17:56, Steven Rostedt wrote: > On Mon, 27 Jun 2016 15:54:33 +0200 > Petr Mladek wrote: > > > 1st patch adds one more paranoid check of the modified function on x86. > > > > Plus there are 3 small changes that appeared when hunting down > > the 1st patch. > > > > Petr Mladek (4): > > ftrace/x86: Make sure to modify 5-bite instructions > > ftrace/x86: Do not crash when reading wrong ftrace func > > The first two are mostly just "detect error, when it happens again" > chanes. Yup. > > ftrace: Always destroy trampoline when shutting down the trace > > ftrace: Fixup trace_selftest_ops() > > These two seem to fix real bugs. I'm thinking they should go in now and > be backported via stable. > > Thoughts? Makes sense. Should I do anything, please? Best Regards, Petr