From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbcF2OgY (ORCPT ); Wed, 29 Jun 2016 10:36:24 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:62399 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbcF2OgW (ORCPT ); Wed, 29 Jun 2016 10:36:22 -0400 From: Arnd Bergmann To: MyungJoo Ham , Chanwoo Choi Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] extcon: link devres into core module Date: Wed, 29 Jun 2016 16:38:30 +0200 Message-Id: <20160629143854.125013-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:u5aB5rtaL/g7RQV05+2goCBTGsNL9C5SoGhwN2KYkl74r1hTmAh O+GA6al4x147M7pPsCE5jnwM6vac2Jk0q7HienGroinsRVQfi0VOwbGpdJoPbnQsxmbOfrO QE/CTH0rYwvLSlNhkPUAlft/eANvJvqas3FYofgZvQ5dClzSQl6wTJT6WBNYJ8j3RNfEHe1 +qu07TYOJSZfCbB9dIyFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:t2EchvmaGoQ=:+bv4A1BeoHHD1DVkvJgspy 6mVoaffg8gwoaUronO5FOFE2dYWDdKL0WbMmXI+ppU9PuBV3fqkglZRQtb3bLRZuMowyI2LVj v+yUOjvHoZtuFcxHQGUX6+4uZtMKi0qv6Z9tWGx4bBrxHM6BTANvek9rNMflIauppVYrsGSlG JG0HAEc+BAG3sXP7TybKJmSs4ctFf3LVRy09+2AlaouBdLhMfXB7YeFBi44gM3UFHuMqA/xf4 GsPB7pswruKlNCcaVvAPdAz/eNyHsaxSWiYm4lfvi4Jh9vot/91+pIdpgqaUqCEbxGJnsnnw5 +sIH5NKv5n4HoYumxqwsjIIJhg4G6u8M6hcBpldWjJYEIFy0n8N6OadkEkrSKJVm9wNGDPgV6 i6s0qFoi10Dkyj0LVmTuUe4tTFvrSGYHxMcG+vS3uvB70vS0a8QiFtifB+nvjz2YJ4aBi+rQi sCuDvTeikAhHvLSBQ8Dz3NUkIwTHyBPWSOh8Ehx7+97vOmcAZDuzfmGvYzYCyZqQfjQ2b3kD3 Met6I5PPrSGxwtHcpYNGhVzFr775c8GmTJm1t2XsWLO++6Fd22fuhV+F0ZzHbfHgR4gHW8sj7 ofz5Zzyc6pvKHzc3qY10s43W+eqFWixt2y6oZzbyrEu+1OuwhxaFG9FH2iBBOxJkCMVYimdS3 FNvjTzjrY2VS5PL5MnmX2SZIxoZXomMu9BFy6NH1UfpGpp6ry4Z2ryychGV0Kq8EG748= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Splitting the resource-managed functions into a separate module means that the extcon core now fails to build because the internal "extcon_dev_allocate" symbol is not exported: ERROR: extcon_dev_allocate [drivers/extcon/devres.ko] undefined! My guess is that the intention was not to have two separate modules (which could be fixed by adding an export, plus the normal MODULE_AUTHOR/MODULE_LICENSE/... fields), but have two source files in the same module. This fixes the Makefile accordingly, making the name of the module extcon_core.ko, which is created from building both extcon.c and devres.c. Signed-off-by: Arnd Bergmann Fixes: b225d00f3ad2 ("extcon: Split out the resource-managed functions from extcon core") --- drivers/extcon/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile index 423ebc8714c5..972c813c375b 100644 --- a/drivers/extcon/Makefile +++ b/drivers/extcon/Makefile @@ -2,7 +2,8 @@ # Makefile for external connector class (extcon) devices # -obj-$(CONFIG_EXTCON) += extcon.o devres.o +obj-$(CONFIG_EXTCON) += extcon-core.o +extcon-core-objs += extcon.o devres.o obj-$(CONFIG_EXTCON_ADC_JACK) += extcon-adc-jack.o obj-$(CONFIG_EXTCON_ARIZONA) += extcon-arizona.o obj-$(CONFIG_EXTCON_AXP288) += extcon-axp288.o -- 2.9.0