From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbcF2TYP (ORCPT ); Wed, 29 Jun 2016 15:24:15 -0400 Received: from sauhun.de ([89.238.76.85]:52161 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbcF2TYO (ORCPT ); Wed, 29 Jun 2016 15:24:14 -0400 Date: Wed, 29 Jun 2016 21:23:57 +0200 From: Wolfram Sang To: Amitoj Kaur Chawla Cc: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.com, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource Message-ID: <20160629192357.GA9260@tetsubishi> References: <20160629183347.GA17067@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <20160629183347.GA17067@amitoj-Inspiron-3542> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: > This script detects cases which have incorrect error handling for > devm_ioremap_resource function, employing a NULL test instead of an > IS_ERR() test. >=20 > Signed-off-by: Amitoj Kaur Chawla Why don't we fix the code at the same time? And it should not be restricted to devm_ioremap_resource() but extensible so other functions could be added later? (Surprised to see that we don't have such a script yet) --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXdCBMAAoJEBQN5MwUoCm2IaMP+gJ5T/ZRUaScqPx1rTE2S5BT 5Wt7nGbV6IO1c5JxLlTFISnzCH75JHBMQMvNx4Tgqh8MJ6W3Eu7X/t2joxQwKuD0 Zflj9m3qQEliuARkJp1bkJ27/AixzX3s5az8zQxUGjC4mfyZzSDhYTg4QSSI7I2X QoSExLcMATzMFmpQd9mC45gzRMYFT69zArOLltBDIFuhs7T9aU7gwys/OhHWlrFk CypSy8R7Ip/gpkHoroOjjjJWUC1Cf15BmfnFneQIvytWD2yK9XFxXgW9+dI4m8q9 f74UgQHDpna7VoryjGuR1yfG5jkDoMb19AXAgMHBHxRakusj+IfsGn1fL92k6547 H3BoD0drrJPRh6f/TIn5WjiTF+0Ohd1nxg203mEdw/2QR4Hle9YM4/9UGYBTzdLQ bcC69FF8lC1xL4qte26UNN+ikUPUB/1+AbUyT+8bSRonIj/7JOFY7SSOEt75FoBj tirscvsDyjYqiwZzCl92OVEqp6qSvMHdLkY5o0uR+KnQsjP3WbX9D2Cd9oEb93F5 Xfj+19yKQBgTS8csM55YrMqT+wC2okMnHrEfDT2CYXMEwBo0XtZHdXQaGWnr/6Ty HsSEqu/CqkMJdwCAwjQGGK2opPMPOZuhrD6uIWe2FJBkvM0jajX7ZpOsuUWkGEFp jR0O20IGciT9/gxIZpiL =XDxw -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--