From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751845AbcF2TeV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2016 15:34:21 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:34420 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750932AbcF2TeT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2016 15:34:19 -0400
Date: Wed, 29 Jun 2016 21:32:44 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org, tglx@linutronix.de, acme@redhat.com,
        mingo@kernel.org, jolsa@redhat.com, vincent.weaver@maine.edu,
        eranian@google.com, alexander.shishkin@linux.intel.com, hpa@zytor.com,
        kan.liang@intel.com, torvalds@linux-foundation.org, davidcc@google.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers
Message-ID: <20160629193244.GZ30921@twins.programming.kicks-ass.net>
References: <tip-d4cf1949f9689314aef962eea95df84a8288d097@git.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tip-d4cf1949f9689314aef962eea95df84a8288d097@git.kernel.org>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 27, 2016 at 05:56:02AM -0700, tip-bot for Peter Zijlstra wrote:
> +static inline u64 rdlbr_from(unsigned int idx)
> +{
> +	u64 val;
> +
> +	rdmsrl(x86_pmu.lbr_from + idx, val);
> +
> +	return lbr_from_signext_quirk_rd(val);
> +}
> +
> +static inline u64 rdlbr_to(unsigned int idx)
> +{
> +	u64 val;
> +
> +	rdmsrl(x86_pmu.lbr_from + idx, val);

Things work loads better when we use:

	rdmsrl(x86_pmu.lbr_to + idx, val);

:-/

> +
>  	return val;
>  }