From: David Miller <davem@davemloft.net>
To: thloh@altera.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, preid@electromag.com.au,
dinguyen@opensource.altera.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
thloh85@gmail.com, cnphoon@altera.com
Subject: Re: [PATCH V6 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
Date: Thu, 30 Jun 2016 08:34:33 -0400 (EDT) [thread overview]
Message-ID: <20160630.083433.705935493078392286.davem@davemloft.net> (raw)
In-Reply-To: <1467191413-16715-1-git-send-email-thloh@altera.com>
From: <thloh@altera.com>
Date: Wed, 29 Jun 2016 02:10:13 -0700
> +static void auto_nego_timer_callback(unsigned long data)
> +{
> + u16 val = 0;
> + u16 speed = 0;
> + u16 duplex = 0;
> +
> + struct tse_pcs *pcs = (struct tse_pcs *)data;
> + void __iomem *tse_pcs_base = pcs->tse_pcs_base;
> + void __iomem *sgmii_adapter_base = pcs->sgmii_adapter_base;
Please do not break up a set of local variable declarations with
an empty line.
> + if ((tse_pcs_base) && (sgmii_adapter_base))
Unnecessary parenthesis.
> + if ((tse_pcs_base) && (sgmii_adapter_base))
Likewise.
> @@ -88,9 +104,13 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
> struct device_node *np = dev->of_node;
> struct regmap *sys_mgr_base_addr;
> u32 reg_offset, reg_shift;
> - int ret;
> - struct device_node *np_splitter;
> + int ret, index;
> + struct device_node *np_splitter = NULL;
> + struct device_node *np_sgmii_adapter = NULL;
> +
> struct resource res_splitter;
> + struct resource res_tse_pcs;
> + struct resource res_sgmii_adapter;
Again, do not break up local variable declarations with an empty line
like this.
next prev parent reply other threads:[~2016-06-30 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 9:10 thloh
2016-06-30 12:34 ` David Miller [this message]
2016-07-01 1:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630.083433.705935493078392286.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=cnphoon@altera.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=thloh85@gmail.com \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®