From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbcF3IUm (ORCPT ); Thu, 30 Jun 2016 04:20:42 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37295 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbcF3IUk (ORCPT ); Thu, 30 Jun 2016 04:20:40 -0400 Date: Thu, 30 Jun 2016 10:19:09 +0200 From: Michal Hocko To: Oleg Nesterov Cc: Andrew Morton , Tetsuo Handa , Vladimir Davydov , David Rientjes , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Message-ID: <20160630081909.GF18783@dhcp22.suse.cz> References: <1467201562-6709-1-git-send-email-mhocko@kernel.org> <20160629192232.GA19097@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160629192232.GA19097@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 29-06-16 21:22:33, Oleg Nesterov wrote: > On 06/29, Michal Hocko wrote: > > > > But it seems that further changes I am > > planning in this area will benefit from stable task->mm in this path > > Oh, so I hope you will cleanup this later, > > > Just pull the task->mm != > > NULL check inside the function. > > OK, but this means it will always return false if the task is a zombie > leader. > > I am not really arguing and this is not that bad, but this doesn't look > nice and imo asks for cleanup. I will keep that in mind and hopefully we can make this less obscure. Who would like zombie leaders lurking around ;) -- Michal Hocko SUSE Labs