From: Jonathan Corbet <corbet@lwn.net>
To: Markus Heiser <markus.heiser@darmarIT.de>
Cc: mchehab@osg.samsung.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, jani.nikula@intel.com,
hverkuil@xs4all.nl, daniel.vetter@ffwll.ch, airlied@gmail.com,
grant.likely@secretlab.ca, rdunlap@infradead.org,
keithp@keithp.com
Subject: Re: [PATCH] doc: flat-table directive
Date: Thu, 30 Jun 2016 13:05:11 -0600 [thread overview]
Message-ID: <20160630130511.34b732e6@lwn.net> (raw)
In-Reply-To: <1467288022-10496-1-git-send-email-markus.heiser@darmarIT.de>
On Thu, 30 Jun 2016 14:00:21 +0200
Markus Heiser <markus.heiser@darmarIT.de> wrote:
> this is my flat-table patch on top of your docs-next branch / we discussed on
> the ML
Hmm... we don't have an official kernel coding style for Python, but if
we did, I'd sure like it to be a lot more like the usual Python
conventions.
The added documentation describes the "widths" parameter, but does not
tell the reader which units are used.
There were also a lot of typos and misspellings in the documentation
addition.
Anyway, I don't want to delay this work, so I have gone ahead and applied
it; I fixed the spelling errors on the way. When you get a chance, can I
get a doc tweak for :widths:?
Thanks for separating this work out,
jon
next prev parent reply other threads:[~2016-06-30 19:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:00 Markus Heiser
2016-06-30 12:00 ` [PATCH] doc-rst: flat-table directive - initial implementation Markus Heiser
2016-06-30 19:05 ` Jonathan Corbet [this message]
2016-06-30 19:31 ` [PATCH] doc: flat-table directive Mauro Carvalho Chehab
2016-06-30 19:44 ` Mauro Carvalho Chehab
2016-07-01 8:44 ` Markus Heiser
2016-07-01 9:38 ` Mauro Carvalho Chehab
2016-07-01 10:44 ` Jani Nikula
2016-07-01 11:12 ` Markus Heiser
2016-07-01 11:56 ` Jani Nikula
2016-07-01 12:03 ` [docs-next PATCH] Documentation: add cleanmediadocs to the documentation targets Jani Nikula
2016-07-01 12:24 ` [docs-next PATCH] Documentation/sphinx: skip build if user requested specific DOCBOOKS Jani Nikula
2016-07-01 12:31 ` Markus Heiser
2016-07-01 13:15 ` Mauro Carvalho Chehab
2016-07-01 13:31 ` Jani Nikula
2016-07-01 15:09 ` Mauro Carvalho Chehab
2016-07-01 12:04 ` [PATCH] doc: flat-table directive Markus Heiser
2016-07-01 12:26 ` Jani Nikula
2016-07-01 13:06 ` Mauro Carvalho Chehab
2016-07-01 12:52 ` Mauro Carvalho Chehab
2016-07-01 12:58 ` Jonathan Corbet
2016-07-01 14:45 ` Markus Heiser
2016-07-01 17:24 ` Jani Nikula
2016-07-01 18:17 ` Mauro Carvalho Chehab
2016-07-01 18:47 ` Jani Nikula
2016-07-01 12:18 ` Markus Heiser
2016-07-01 12:59 ` Mauro Carvalho Chehab
2016-07-01 13:09 ` Jani Nikula
2016-07-01 14:07 ` Markus Heiser
2016-07-01 15:00 ` Mauro Carvalho Chehab
2016-07-01 15:01 ` Mauro Carvalho Chehab
2016-07-06 22:58 ` Mauro Carvalho Chehab
2016-07-01 12:08 ` Jani Nikula
2016-07-01 6:35 ` Markus Heiser
2016-07-01 18:25 ` Captions numbering support Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630130511.34b732e6@lwn.net \
--to=corbet@lwn.net \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=grant.likely@secretlab.ca \
--cc=hverkuil@xs4all.nl \
--cc=jani.nikula@intel.com \
--cc=keithp@keithp.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.heiser@darmarIT.de \
--cc=mchehab@osg.samsung.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome