From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752934AbcGAJSm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jul 2016 05:18:42 -0400
Received: from mail.skyhub.de ([78.46.96.112]:36838 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752910AbcGAJSi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jul 2016 05:18:38 -0400
Date: Fri, 1 Jul 2016 11:07:40 +0200
From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
	<u.kleine-koenig@pengutronix.de>,
        Franck Bui <fbui@suse.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages
 on release
Message-ID: <20160701090740.GB4593@pd.tnic>
References: <1467194161-1472-1-git-send-email-bp@alien8.de>
 <1467194161-1472-2-git-send-email-bp@alien8.de>
 <20160701082247.GA27709@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160701082247.GA27709@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 01, 2016 at 10:22:47AM +0200, Ingo Molnar wrote:
> > +/* issue num suppressed message on exit */
> > +#define RATELIMIT_MSG_ON_RELEASE	BIT(0)
> 
> So this flag says that we should issue a ratelimit message when it occurs.

This flag says that we should print the ratelimit message when we
release the ratelimit state, i.e., devkmsg_release() for example.

> But here we print the message if the RATELIMIT_MSG_ON_RELEASE bit is zero.
> Is that intentional?

Sure, we want to dump the ratelimited messages only when we release the
ratelimit state.

> Also, while we are changing it, I'd like to suggest a different message - it's 
> talking about 'callbacks' but there's no callback here - we are skipping kernel 
> log messages. So how about:
> 
> 	pr_warn("%s: %d kernel log lines skipped, due to rate-limiting.\n"

Well, I'm not sure: even though the majority of the ratelimit usage is
printing stuff and it has been carved out from printk.c, it still is a
generic facility and you probably want to ratelimit other things too
with it, like polling for something or whatnot.

  [ Whether it is really usable for something else besides ratelimiting
    printk is a whole another question, of course. ]

And ___ratelimit() itself gets a function name as arg so there you
*really* *have* callbacks so %d callbacks suppressed\n" is actually
correct.

I guess I can make the RATELIMIT_MSG_ON_RELEASE message more generic:

static inline void ratelimit_state_exit(struct ratelimit_state *rs)
{
        if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE))
                return;

        if (rs->missed)
                printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n",
                       current->comm, rs->missed);
}

?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.