From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcGANUS (ORCPT ); Fri, 1 Jul 2016 09:20:18 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33414 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbcGANUN (ORCPT ); Fri, 1 Jul 2016 09:20:13 -0400 Date: Fri, 1 Jul 2016 14:19:59 +0100 From: Chris Wilson To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v2 2/4] dma-buf/sync_file: rework fence storage in struct file Message-ID: <20160701131959.GD1306@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= References: <1467378307-28088-1-git-send-email-gustavo@padovan.org> <1467378307-28088-3-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467378307-28088-3-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2016 at 10:05:05AM -0300, Gustavo Padovan wrote: > @@ -333,16 +384,16 @@ static long sync_file_ioctl_fence_info(struct sync_file *sync_file, > if (!info.num_fences) > goto no_fences; > > - if (info.num_fences < sync_file->num_fences) > + if (info.num_fences < num_fences) > return -EINVAL; > > - size = sync_file->num_fences * sizeof(*fence_info); > + size = num_fences * sizeof(*fence_info); > fence_info = kzalloc(size, GFP_KERNEL); Does size get used elsewhere? Otherwise it would be safer to reduce this to kcalloc(num_fences, sizeof(*fence_info), GFP_KERNEL) > if (!fence_info) > return -ENOMEM; > > diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c > index 5f57499..0638a06 100644 > --- a/drivers/staging/android/sync_debug.c > +++ b/drivers/staging/android/sync_debug.c > @@ -159,10 +159,15 @@ static void sync_print_sync_file(struct seq_file *s, > int i; > > seq_printf(s, "[%p] %s: %s\n", sync_file, sync_file->name, > - sync_status_str(atomic_read(&sync_file->status))); > - > - for (i = 0; i < sync_file->num_fences; ++i) > - sync_print_fence(s, sync_file->cbs[i].fence, true); > + sync_status_str(!fence_is_signaled(sync_file->fence))); > + > + if (fence_is_array(sync_file->fence)) { > + struct fence_array *array = to_fence_array(sync_file->fence); checkpatch will complain about the missing line between decl and code -Chris -- Chris Wilson, Intel Open Source Technology Centre