From: Andrey Pronin <apronin@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/4] spi: Add option to wake a device by toggling CS
Date: Fri, 1 Jul 2016 18:45:52 -0700 [thread overview]
Message-ID: <20160702014551.GB27937@apronin0.mtv.corp.google.com> (raw)
In-Reply-To: <20160701080230.GB6247@sirena.org.uk>
On Fri, Jul 01, 2016 at 09:02:30AM +0100, Mark Brown wrote:
> On Wed, Jun 29, 2016 at 08:54:24PM -0700, apronin@chromium.org wrote:
> > From: Andrey Pronin <apronin@chromium.org>
> >
> > Some SPI devices may go to sleep after a period of inactivity
> > on SPI. For such devices, if enough time has passed since the
> > last SPI transaction, toggle CS and wait for the device to
> > start before communicating with it.
>
> This seems incredibly specialist, I can imagine someone might implement
> something like this but it really feels like something I'd expect the
> driver for the device to be doing rather than the core. Is it really a
> bounce that's needed and not something like putting a small delay after
> asserting chip select?
Yes, I agree it's quite device-specific, though, I guess, more than a
single device can benefit from that. I'm playing with it now to see if
I can indeed move it to a more device-specific driver from generic spi.
It is indeed a bounce and a rather long delay to let the device actually
wake from a long sleep, go through internal startup, test, etc.
prev parent reply other threads:[~2016-07-02 1:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 3:54 apronin
2016-06-30 3:54 ` [PATCH 2/4] spi: Document " apronin
2016-06-30 7:12 ` Geert Uytterhoeven
2016-07-01 4:32 ` Doug Anderson
2016-06-30 3:54 ` [PATCH 3/4] spi: Add option to insert delay between transactions apronin
2016-07-01 4:44 ` Doug Anderson
2016-07-01 8:16 ` Mark Brown
2016-06-30 3:54 ` [PATCH 4/4] spi: Document " apronin
2016-06-30 7:12 ` Geert Uytterhoeven
2016-07-01 4:45 ` Doug Anderson
2016-07-01 4:23 ` [PATCH 1/4] spi: Add option to wake a device by toggling CS Doug Anderson
2016-07-01 8:21 ` Mark Brown
2016-07-01 17:05 ` Doug Anderson
2016-07-01 17:17 ` Mark Brown
2016-07-02 2:02 ` Andrey Pronin
2016-07-01 8:02 ` Mark Brown
2016-07-02 1:45 ` Andrey Pronin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160702014551.GB27937@apronin0.mtv.corp.google.com \
--to=apronin@chromium.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®