From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751563AbcGDEUK (ORCPT ); Mon, 4 Jul 2016 00:20:10 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:38028 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbcGDEUG (ORCPT ); Mon, 4 Jul 2016 00:20:06 -0400 X-AuditID: cbfee68d-f79876d000001436-51-5779e3f37175 Date: Mon, 04 Jul 2016 13:20:03 +0900 From: Andi Shyti To: Tomasz Figa Cc: Chanwoo Choi , Jaehoon Chung , Sylwester Nawrocki , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, linux-arm-kernel , linux-kernel , Andi Shyti Subject: Re: [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Message-id: <20160704042003.GB23620@samsunx.samsung> References: <1467270911-10971-1-git-send-email-andi.shyti@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsWyRsSkQPfz48pwg6aX8haLfzxnsrj+5Tmr xY1fbawWr18YWvQ/fs1ssenxNVaLjz33WC0u75rDZjHj/D4mi4unXC0Ov2lntfhxppvFYtWu P4wOvB7vb7Sye1zu62XyuL7kE7PHzll32T02repk89i8pN6jb8sqRo/Pm+QCOKK4bFJSczLL Uov07RK4Mh5uPs1ScIanYvnh2YwNjOc4uxg5OSQETCQaZjexQthiEhfurWfrYuTiEBJYwSjx cfohNpii/gXHmSESSxklJh3azQrhfGSUWLPvNFgVi4CqxJwH5xhBbDYBTYmm2z/A4iIC6hLf pvSzgzQwC8xgkWiYsogFJCEs4CfR9G4KUIKDgxdoxb7eIoihDxklTp9dBzaIV0BQ4sfke2D1 zAJaEut3HmeCsKUlHv2dwQ5icwoESzzuesgCMkdUQFni7rIgkDkSAlM5JH4cOsIKcZyAxLfJ h8BqJARkJTYdYIb4TFLi4IobLBMYxWYh2TYLybZZSLYtYGRexSiaWpBcUJyUXmSoV5yYW1ya l66XnJ+7iREYzaf/PevdwXj7gPUhRgEORiUeXoaYynAh1sSy4srcQ4ymQFdMZJYSTc4Hpoy8 knhDYzMjC1MTU2Mjc0szJXFeRamfwUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY7wqdkPP8 9GfXptuyn3dsOuddI6HOdPn/3t8dB29c+hJ6w0163eX8lx7Lp0pGM/d//Z4lo+H5Il88kJWp 9T2v+95Q7jeV21S+srDMPR795YVEs2fV3yuv7GcdTXIOfzfh//2t+fHNu3vlNbRn31lYWKT0 m/dmSY3uwcYfQU2iWu09V6vdG1I8lFiKMxINtZiLihMBKeqUJ+ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jAd3PjyvDDU7skLRY/OM5k8X1L89Z LW78amO1eP3C0KL/8Wtmi02Pr7FafOy5x2pxedccNosZ5/cxWVw85Wpx+E07q8WPM90sFqt2 /WF04PV4f6OV3eNyXy+Tx/Uln5g9ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBHVwGiTkZqY klqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SxkkJZYk4pUCgg sbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjHj4ebTLAVneCqWH57N2MB4jrOLkZNDQsBE on/BcWYIW0ziwr31bF2MXBxCAksZJSYd2s0K4XxklFiz7zQbSBWLgKrEnAfnGEFsNgFNiabb P8DiIgLqEt+m9LODNDALzGCRaJiyiAUkISzgJ9H0bgpQgoODF2jdvt4iiKEPGSVOn10HNohX QFDix+R7YPXMAloS63ceZ4KwpSUe/Z3BDmJzCgRLPO56yAIyR1RAWeLusqAJjAKzkHTPQtI9 C0n3AkbmVYwSqQXJBcVJ6bmGeanlesWJucWleel6yfm5mxjBCeOZ1A7Gg7vcDzEKcDAq8fBa 9laGC7EmlhVX5h5ilOBgVhLhvXQPKMSbklhZlVqUH19UmpNafIjRFBggE5mlRJPzgcksryTe 0NjEzMjSyNzQwsjYXEmc9/H/dWFCAumJJanZqakFqUUwfUwcnFINjCH3QlaHsYQ5vK3ayMK6 aEK6ftFWjqOyibxajT17/D3umq9aZ/tVxl5+95y7z476TrF8dNJ1atG0vxekpy8R6M8M3dpy wimd/7jeKrdmfXGb1oc1JYcnHNl+xeXHj13ai6w9WrfGmKwIUbl9eN7cJ4GJX96HGK/Tdy3j dZTk2zZzye7LnMeXtSqxFGckGmoxFxUnAgA8Y+lxLgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz, > > This patchset enables spi3 clocks by marking critical clocks as > > CLK_IS_CRITICAL and in the meantime replaces the use of > > CLK_IGNORE_UNUSED for spi1 clocks. > > > > The sclk needs to be considered critical as well. > > > > The SPI3 in the tm2/tm2e boards will control an irled for remote > > controlling. > > > > Changelog: > > > > V1 -> V2 > > - the "sclk_spi3" doesn't need to be enabled in boot time as it > > is handled by the spi driver itself. > > > > - use the CLK_IS_CRITICAL flag for the ioclk > > > > V2 -> V3 > > - some more tests has confirmed taht "sclk_spi1,3" need to be > > enabled as critical! > > This sounds like a DTS and/or SPI and/or clock driver bug then. I'm > pretty much convinced that it might also cause other problems and this > workaround will only mask them making things even more difficult to > debug in the future. Let's not introduce more technical debt. In principle I agree, but, the upcoming TM2/TM2e boards will have the audio codec connected on SPI1 and the ir remote controller on the SPI3 (others SPI slots are used as well, but we don't have the drivers ready for them). I followed for SPI3 the same approach as it was done for SPI1, so that I see two choices here: * reject this patches and cleanup the SPI1 from the "technical debt" and not have anything working on spi. or * do for SPI3 the same as it has been done for SPI1 (and as it is now) with its "technical debt". I did quite an extensive testing on these lines and I don't see any other alternative. Thanks, Andi