From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbcGDING (ORCPT ); Mon, 4 Jul 2016 04:13:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40116 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbcGDINE (ORCPT ); Mon, 4 Jul 2016 04:13:04 -0400 Date: Mon, 4 Jul 2016 10:12:38 +0200 From: Mark Brown To: Baoquan He Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20160704081238.GQ6247@sirena.org.uk> References: <1467597925-10490-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pvGBTzZYFChjGQji" Content-Disposition: inline In-Reply-To: <1467597925-10490-1-git-send-email-bhe@redhat.com> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.22.87 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pvGBTzZYFChjGQji Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 04, 2016 at 10:05:25AM +0800, Baoquan He wrote: > In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) > type of variable has_full_constraints is changed to bool, so assign 'true' > to has_full_constraints here. There is no need to make changes like this, C has full support for using integers in a boolean context - using true here would've been just as meaningful with an integer variable and using a number for a boolean variable is fully equivalent. --pvGBTzZYFChjGQji Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXehppAAoJECTWi3JdVIfQHzMH/3ld/5SvkVK9T38ZmQoJdnIh giK1oo2kqqg4N6+nJJOH+h+YsWdZhMs7dwz8HIRgP/f9IYO53z8MZjW3AaH8/9Tu h++qp/aqSMMZtmwCQxGDC0Iz+Ny42Uv/HAA46HYJTicJ9B3b2389fhrx7UssR4W9 fvDCxqe51pIUIrK2lQVdbWY70C31AelezMsApNRrHyBxaAnrJVkKCnGaoI3DOZdI 8K2Jc2lc4Pze0VYXxb+8gpV+OU8swux075M5rrHRiiwRH2D0n1ipL3dCr0kP+wWI NdXprUFQaTVfUym2CdddJ7PDEy5J1I7+ZOANnvwoseop40abXL/g2gMqSwKQxfs= =1l9t -----END PGP SIGNATURE----- --pvGBTzZYFChjGQji--