From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441AbcGDJKH (ORCPT ); Mon, 4 Jul 2016 05:10:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40330 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753344AbcGDJKD (ORCPT ); Mon, 4 Jul 2016 05:10:03 -0400 Date: Mon, 4 Jul 2016 11:09:43 +0200 From: Mark Brown To: Baoquan He Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20160704090943.GW6247@sirena.org.uk> References: <1467597925-10490-1-git-send-email-bhe@redhat.com> <20160704081238.GQ6247@sirena.org.uk> <20160704083826.GC4634@x1.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qnuS/wU1MXEWeKjo" Content-Disposition: inline In-Reply-To: <20160704083826.GC4634@x1.redhat.com> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.22.87 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qnuS/wU1MXEWeKjo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 04, 2016 at 04:38:26PM +0800, Baoquan He wrote: > By the way, I still think it makes code more read-able to assign a bool > value to a bool variable. In your words, C truly has full support for > using integers in a boolean context, then commit 21cf891a is not > necessary to be made to change. The feedback here is largely about the commit message - it's written like it's fixing a bug but it's really just a stylistic change. --qnuS/wU1MXEWeKjo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXeifVAAoJECTWi3JdVIfQOfEH/iP0NlbNaKLSktS0/lBXER0i HhAf2VDMRWta1U47u1f2MFrElR+LW8EAtZ7UIucCkWQ1c6BpYzLxsdJkOy27sf5J GBDglYJJhPyqYFbcO2zKtju5W2TXoP7RNNtgJDg83C0VUEnA5vFTCkp0GCNxWm4X MM+l03BPn4OwXSfmYhMPwj7XhPtj4BoXIgZFmUJIMh2NL5suDNrz/qPAO16U4lpW RiYF9e4X3p+3kzqHhQDwvDn1IgrzTod+kWAwt8MOxtS354TvgVe6s0Zxj4bIpoMN LI0KGh2yYEDJo6u3822DUc9hysEdKaDF1S14S5Qt1Pspna7UyTppSgcajmiP63M= =WMTZ -----END PGP SIGNATURE----- --qnuS/wU1MXEWeKjo--