mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Rothberg <valentinrothberg@gmail.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] checkkconfigsymbols.py: add --no-color option
Date: Mon, 4 Jul 2016 12:44:03 +0200	[thread overview]
Message-ID: <20160704104403.qe74rkyt6ix3nqrk@susevm> (raw)
In-Reply-To: <1467621570-970-1-git-send-email-andrew.donnellan@au1.ibm.com>

Hi Andrew,

thanks for your patch.  Please remove the colour comment from the commit
message and resend the patch.  Such comments are better below the '---'.

On Jul 04 '16 18:39, Andrew Donnellan wrote:
> Add a new option, --no-color, to get rid of ANSI colour escape codes in the
> output. Useful if redirecting output to a file or piping to another script.
> 
> (It should really be --no-colour, but I'll accept US spelling in the name
> of consistency with existing usage in the code comments...)
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

Acked-by: Valentin Rothberg <valentinrothberg@gmail.com>

Thanks,
 Valentin
> ---
>  scripts/checkkconfigsymbols.py | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
> index df643f6..a9eba02 100755
> --- a/scripts/checkkconfigsymbols.py
> +++ b/scripts/checkkconfigsymbols.py
> @@ -82,6 +82,10 @@ def parse_options():
>                        default=False,
>                        help="Reset current Git tree even when it's dirty.")
>  
> +    parser.add_option('', '--no-color', dest='no_color', action='store_true',
> +                      default=False,
> +                      help="Don't print colored output.")
> +
>      (opts, _) = parser.parse_args()
>  
>      if opts.commit and opts.diff:
> @@ -116,6 +120,9 @@ def main():
>      """Main function of this module."""
>      opts = parse_options()
>  
> +    global no_color
> +    no_color = opts.no_color
> +
>      if opts.sim and not opts.commit and not opts.diff:
>          sims = find_sims(opts.sim, opts.ignore)
>          if sims:
> @@ -202,14 +209,14 @@ def yel(string):
>      """
>      Color %string yellow.
>      """
> -    return "\033[33m%s\033[0m" % string
> +    return string if no_color else "\033[33m%s\033[0m" % string
>  
>  
>  def red(string):
>      """
>      Color %string red.
>      """
> -    return "\033[31m%s\033[0m" % string
> +    return string if no_color else "\033[31m%s\033[0m" % string
>  
>  
>  def execute(cmd):
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> andrew.donnellan@au1.ibm.com  IBM Australia Limited
> 

  reply	other threads:[~2016-07-04 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04  8:39 Andrew Donnellan
2016-07-04 10:44 ` Valentin Rothberg [this message]
2016-07-04 12:24 ` Josh Triplett
2016-07-05  7:22   ` Andrew Donnellan
2016-07-05  7:47 ` [PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY Andrew Donnellan
2016-07-05  8:45   ` Valentin Rothberg
2016-08-16  8:25   ` Valentin Rothberg
2016-08-16 10:49     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704104403.qe74rkyt6ix3nqrk@susevm \
    --to=valentinrothberg@gmail.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®