From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753883AbcGDUYK (ORCPT ); Mon, 4 Jul 2016 16:24:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52720 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753725AbcGDUYI (ORCPT ); Mon, 4 Jul 2016 16:24:08 -0400 Date: Mon, 4 Jul 2016 22:24:04 +0200 From: Boris Brezillon To: Alexandre Belloni Cc: Daniel Lezcano , Thomas Gleixner , Nicolas Ferre , Olivier Schonken , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource: timer-atmel-pit: enable mck Message-ID: <20160704222404.5132c3d3@bbrezillon> In-Reply-To: <1467648009-24269-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1467648009-24269-1-git-send-email-alexandre.belloni@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Jul 2016 18:00:09 +0200 Alexandre Belloni wrote: > mck is needed to get the PIT working. Explicitly prepare_enable it instead > of assuming it is enabled. > > This solves an issue were the system is freezing when the ETM/ETB drivers ^ where > are enabled. > > Reported-by: Olivier Schonken > Signed-off-by: Alexandre Belloni Reviewed-by: Boris Brezillon > --- > drivers/clocksource/timer-atmel-pit.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c > index d911c5dca8f1..fcc97711cd79 100644 > --- a/drivers/clocksource/timer-atmel-pit.c > +++ b/drivers/clocksource/timer-atmel-pit.c > @@ -248,6 +248,9 @@ static void __init at91sam926x_pit_dt_init(struct device_node *node) > if (IS_ERR(data->mck)) > panic(pr_fmt("Unable to get mck clk\n")); > > + if (clk_prepare_enable(data->mck)) > + panic(pr_fmt("Unable to enable mck\n")); > + > /* Get the interrupts property */ > data->irq = irq_of_parse_and_map(node, 0); > if (!data->irq)