From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/4] perf tools: Do the error path hist_entry release in hist_entry__new
Date: Tue, 5 Jul 2016 08:32:15 +0200 [thread overview]
Message-ID: <20160705063215.GB15745@krava> (raw)
In-Reply-To: <20160704190947.GW5324@kernel.org>
On Mon, Jul 04, 2016 at 04:09:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jul 04, 2016 at 04:01:37PM +0200, Jiri Olsa escreveu:
> > It's better to release the hist_entry object in
> > hist_entry__new function (where it's allocated)
> > rather than in hist_entry__init.
>
> Please combine this with the previous patch, that way this all gets
> clearer :-\
ok, will change
thanks,
jirka
next prev parent reply other threads:[~2016-07-05 6:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:01 [RFC 0/4] perf tools: Add hist_entry allocation callbacks Jiri Olsa
2016-07-04 14:01 ` [PATCH 1/4] perf tools: Introduce hist_entry__init function Jiri Olsa
2016-07-04 19:08 ` Arnaldo Carvalho de Melo
2016-07-04 14:01 ` [PATCH 2/4] perf tools: Do the error path hist_entry release in hist_entry__new Jiri Olsa
2016-07-04 19:09 ` Arnaldo Carvalho de Melo
2016-07-05 6:32 ` Jiri Olsa [this message]
2016-07-04 14:01 ` [PATCH 3/4] perf tools: Introduce hist_entry_ops Jiri Olsa
2016-07-04 14:01 ` [PATCH 4/4] perf tools: Introduce hists__add_entry_ops function Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705063215.GB15745@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®