From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbcGEQry (ORCPT ); Tue, 5 Jul 2016 12:47:54 -0400 Received: from smtprelay0168.hostedemail.com ([216.40.44.168]:33999 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752851AbcGEQrt (ORCPT ); Tue, 5 Jul 2016 12:47:49 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3873:4321:4605:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13311:13357:13439:14180:14181:14659:14721:14822:21080:21324:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: spoon40_26120232bf152 X-Filterd-Recvd-Size: 2097 Date: Tue, 5 Jul 2016 12:47:40 -0400 From: Steven Rostedt To: Juri Lelli Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luca.abeni@unitn.it Subject: Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160705124740.34a3fbb5@gandalf.local.home> In-Reply-To: <20160705143933.GJ17689@e106622-lin> References: <1467227263-31349-1-git-send-email-juri.lelli@arm.com> <20160705102013.25a1a1dc@gandalf.local.home> <20160705143933.GJ17689@e106622-lin> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jul 2016 15:39:33 +0100 Juri Lelli wrote: return; > > > > > > /* > > > + * Use the scheduling parameters of the top pi-waiter task, > > > + * if we have one from which we can inherit a deadline. > > > + */ > > > + if (pi_task && dl_se->dl_boosted && dl_prio(pi_task->normal_prio)) > > > + pi_se = &pi_task->dl; > > > + > > > > OK, I'm micro-optimizing now, but hey, isn't this a fast path? > > > > What about changing the above to: > > > > struct task_struct *pi_task; > > [...] > > > > if (dl_se->dl_boosted && dl_prio(pi_task->normal_prio && > ^ > OK, we need to reorder these two > V > > (pi_task = rt_mutex_get_top_task(dl_task_of(dl_se))) > > pe_se = &pi_task->dl; Opps, you're right. > > > > This way we don't need to do any work of looking at > > rt_mutex_get_top_task() for the normal case. > > > > But, yes. Looks good to me. I'll shoot a v3 ASAP. I have to ask, should there be any check if the dl_se has a shorter deadline than the pi one? -- Steve