From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755055AbcGEOmA (ORCPT ); Tue, 5 Jul 2016 10:42:00 -0400 Received: from outbound1.eu.mailhop.org ([52.28.251.132]:11330 "EHLO outbound1.eu.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbcGEOl6 (ORCPT ); Tue, 5 Jul 2016 10:41:58 -0400 X-MHO-User: a346aebd-42be-11e6-ac92-3142cfe117f2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.78.160 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io 2A8178017F Date: Tue, 5 Jul 2016 14:41:51 +0000 From: Jason Cooper To: Sebastian Frias Cc: Mason , LKML , Thomas Gleixner , Marc Zyngier Subject: Re: [RFC PATCH v1] irqchip: add support for SMP irq router Message-ID: <20160705144151.GE3348@io.lakedaemon.net> References: <577542D1.4070307@laposte.net> <577A5260.3070001@free.fr> <577BA854.6090503@laposte.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577BA854.6090503@laposte.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Sebastian, Mason, * Please fix mailer to wrap text at a sane length. I've re-wrapped and trimmed. On Tue, Jul 05, 2016 at 02:30:12PM +0200, Sebastian Frias wrote: > On 07/04/2016 02:11 PM, Mason wrote: ... > >> .../sigma,smp87xx-irqrouter.txt | 69 +++ > > > > In the *actual* submission, we can't use a wildcard like smp87xx > > we'll have to use an actual part number. > > Are you sure? > That would hinder genericity. > Actually I wanted to call it "sigma,smp-irqrouter.txt" (or "sigma,smp,irqrouter.txt"). sigma,smp-irqrouter.txt should be fine. The devicetree maintainers should yelp if they want something different. > To me there's no need to link the compatible string of a given HW > module with that of the chip name the module it is embedded into. For > example, the generic USB3 driver is "generic-xhci". While this module > is not generic to be embedded in chips from different manufacturers, > it is supposed to be generic within Sigma, and multiple Sigma chips > (with potentially different denominations) can use it. > > > > >> drivers/irqchip/Makefile | 1 + > >> drivers/irqchip/irq-tango_v2.c | 594 +++++++++++++++++++++ > > > > Likewise, I don't like the "_v2" suffix, it's too generic. > > Actual submission should use something more specific. > > Well, the other driver is irq-tango.c that is generic as well. > I prefer versioning, as it is unrelated with the actual chip name. Is there a name, similar to 'tango', for this version of the IP? Something that would spark recognition for someone looking for "the damn driver for this XYZ irqchip I have". If not, irq-tango_v2.c is fine. thx, Jason.