From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754383AbcGFMvR (ORCPT ); Wed, 6 Jul 2016 08:51:17 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:51229 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbcGFMvQ (ORCPT ); Wed, 6 Jul 2016 08:51:16 -0400 From: Arnd Bergmann To: Linus Walleij , Alexandre Courbot Cc: Alexander Stein , Arnd Bergmann , William Breathitt Gray , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: tegra: don't auto-enable for COMPILE_TEST Date: Wed, 6 Jul 2016 14:54:03 +0200 Message-Id: <20160706125424.1687264-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Po/1TSrp29KQ6U0/xJBvkvnsO0Mn1W+N8yr1Zncv2UpijOBMbcG w/B/vVMVpZVcJPgRYSc64Ap8D/ERbBGOxUydrCUeesuZpFx0As8NTvxdFg3QnJA905cB/JQ IAGrwen74CcVAe+7suHLTgpq2qN8COS64RPsA/63x9hc2kKJ4OiOZ/eMhYDtqx+8fXpYUx8 6qmtW+ZV1ZdF2LcG6rJtQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:GhIhCzFJCME=:I1s6kOOqFXt6OeiLdhWsVb EUKIo4hwxYWWy7WcFfhrRdj1r7+tdV9HwcOky+JdoYsbrIPBKx1bQuzLmqNa/8rEiNO9lgJKB xLCj7L1oA61D8d5v7l1Regur6us8TLTkLRdb5hDbplure6Eh9uEX6PNgrd9Ymr3RAqHrSjEUL p7ZQEak8UuKaqY7L4KmmWuPY15R0ahHrms9LzupZBi5v86CS7Fyj1IB8w7bUdGkKq8qmgHjqG 4Ek5A/yY2gAszu1tKj/frkKfiwjE+M8TTwsueDGZqLWzXOstVO4qEo4336N15SLCcih9GWucu H4LkK/UQiC/7oCNMV2KXH6QaQhWIOeGf6OgUqXj9B9vWuNr3bGyesJf1cRMBqadtjeJrjuiwd 0Kj67io9OdUW2hUyYPpkY2Smr/C4LtHMnwJ2Z1yzLbdjna6RGOPMkFtWyAItLeII8jR8B71bx VvQddAMkfzM8GWM/mohmFlP3/Sgdipd8oiEGWySB86rU9+IYhRn3l6OLzEBg2HNDXHSU1Sj6h NH3aB6K5qOayeQna9kINMuJb4sbAutgXoBgHfzq2u4+ICrmbM/KiL0xHnU6orfnp6iFtiXk9d EOy7S3DsgFnb/QWwYNgRm41oiAiKMt/LhrNC0hWjt65h4avpukMSIAKBWUt+CZGRGogZmmhBB ZYTNjJI0zDTZrlEuqfhW9FZaCX/v7mNfM4MhBUmbu667khUPgKQOkqhrTcuCrARH9Jbo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I stumbled over a build error with COMPILE_TEST and CONFIG_OF disabled: drivers/gpio/gpio-tegra.c: In function 'tegra_gpio_probe': drivers/gpio/gpio-tegra.c:603:9: error: 'struct gpio_chip' has no member named 'of_node' The problem is that the newly added GPIO_TEGRA Kconfig symbol does not have a dependency on CONFIG_OF. However, there is another problem here as the driver gets enabled unconditionally whenever COMPILE_TEST is set. This fixes both problems, by making the symbol user-visible when COMPILE_TEST is set and default-enabled for ARCH_TEGRA=y. As a side-effect, it is now possible to compile-test a Tegra kernel with GPIO support disabled, which is harmless. Signed-off-by: Arnd Bergmann Fixes: 4dd4dd1d2120 ("gpio: tegra: Allow compile test") --- drivers/gpio/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 681c2dcd697b..513a3d174706 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -402,9 +402,12 @@ config GPIO_TB10X select OF_GPIO config GPIO_TEGRA - bool - default y + bool "NVIDIA Tegra GPIO support" + default ARCH_TEGRA depends on ARCH_TEGRA || COMPILE_TEST + depends on OF + help + Say yes here to support GPIO pins on NVIDIA Tegra SoCs. config GPIO_TS4800 tristate "TS-4800 DIO blocks and compatibles" -- 2.9.0