From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754852AbcGFNiq (ORCPT ); Wed, 6 Jul 2016 09:38:46 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34339 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbcGFNio (ORCPT ); Wed, 6 Jul 2016 09:38:44 -0400 Date: Wed, 6 Jul 2016 21:38:41 +0800 From: Minfei Huang To: Mike Snitzer Cc: agk@redhat.com, shli@kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESENT] dm: Check kthread_run's return value Message-ID: <20160706133841.GB1712@MinfeideMacBook-Pro.local> References: <1467645927-4143-1-git-send-email-mnghuan@gmail.com> <20160706131601.GA28379@redhat.com> <20160706132755.GA1712@MinfeideMacBook-Pro.local> <20160706133129.GB28379@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160706133129.GB28379@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/16 at 09:31P, Mike Snitzer wrote: > On Wed, Jul 06 2016 at 9:27am -0400, > Minfei Huang wrote: > > > On 07/06/16 at 09:16P, Mike Snitzer wrote: > > > On Mon, Jul 04 2016 at 11:25am -0400, > > > Minfei Huang wrote: > > > > > > > kthread function is used to process kthread_work. And there is no return > > > > value checking during create this thread. Add this checking to fix this > > > > issue. > > > > > > > > Signed-off-by: Minfei Huang > > > This needed rebasing against linux-dm.git's 'for-next'. I've now staged > > > this fix for 4.8 inclusion, see: > > > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=7193a9defcab6f3d3f1eb64c68bad7534e5a39ad > > > > Seems that we should fix it in stable as well. > > Given the code movement it isn't easy to do (by simply adding a stable@ > cc). I've not seen a single report of an ignored kthread_run() failure > for multipath using .request_fn interface. Yep, this bug will be trigged in very restrict condition, also dm is installed in boot time when there are a lot of memory avaiable. Thanks Minfei