From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030389AbcGGIMw (ORCPT ); Thu, 7 Jul 2016 04:12:52 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52096 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030372AbcGGIEe (ORCPT ); Thu, 7 Jul 2016 04:04:34 -0400 Date: Thu, 7 Jul 2016 10:03:56 +0200 From: Mark Brown To: Boris Brezillon Cc: Douglas Anderson , lee.jones@linaro.org, briannorris@chromium.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , lgirdwood@gmail.com, linux-kernel@vger.kernel.org Message-ID: <20160707080356.GF6247@sirena.org.uk> References: <1467089591-7631-1-git-send-email-dianders@chromium.org> <20160706142719.73713123@bbrezillon> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="02C+GlUcNvfRYA2K" Content-Disposition: inline In-Reply-To: <20160706142719.73713123@bbrezillon> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.23.252 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: pwm: Fix regulator ramp delay for continuous mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --02C+GlUcNvfRYA2K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 06, 2016 at 02:27:19PM +0200, Boris Brezillon wrote: > I realize I may have introduced another bug when adding the > ->enable()/disable() methods: we are only waiting for the ramp up delay > when changing the voltage, but it should probably be applied when > enabling the PWM, and conditionally applied when changing the voltage > only if the PWM is enabled. Yes, it should be applied on enable. =20 --02C+GlUcNvfRYA2K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXfgzrAAoJECTWi3JdVIfQegAH/Alb5c7hQiNVMwlKHXtEwhl5 CVsF/CK3pLnG70tRHqXc+gVPdZeLSs9CxxuWAA8hp5tYIkkMvffoyDNcnshKW/F3 ol0AoQ+uo25qf5JAjcbJXLZA97hGOhiJLwv24MKjfo9fxPYUNMmUKDMsKuud5cck 2Gne/W6LjmdhaqBmluXRkMT9d9ef0KvcR7NNqgXx9pPIqoJMBdzvHv7AmJaauE0d oXVdHIQtTiy/NaQ+wxGJVcX9REqS9wbnSu2EJqTbokrZnWbbr4d4dKUqu1IYKFM5 fXqGW8xs5X6/XmfI8iflUyanmJJTufeZMO2LxgycgAGBW9U9QmDfPEPxEliEKPQ= =2ZsX -----END PGP SIGNATURE----- --02C+GlUcNvfRYA2K--