From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756995AbcGGJnZ (ORCPT ); Thu, 7 Jul 2016 05:43:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52334 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756587AbcGGJnV (ORCPT ); Thu, 7 Jul 2016 05:43:21 -0400 Date: Thu, 7 Jul 2016 11:42:54 +0200 From: Mark Brown To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Message-ID: <20160707094254.GK6247@sirena.org.uk> References: <1467814781-15007-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QLVPfMX7UDLv9S3y" Content-Disposition: inline In-Reply-To: <1467814781-15007-1-git-send-email-p.zabel@pengutronix.de> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.23.252 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: add iopoll-like polling macro X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QLVPfMX7UDLv9S3y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 06, 2016 at 04:19:41PM +0200, Philipp Zabel wrote: > This patch adds a macro regmap_read_poll_timeout that works similar > to the readx_poll_timeout defined in linux/iopoll.h, except that this > can also return the error value returned by a failed regmap_read. Please make this a proper function. > + if (sleep_us) \ > + usleep_range((sleep_us >> 2) + 1, sleep_us); \ Just write / 4 rather than a shift, the compiler should do the right thing and it's easier for readers. --QLVPfMX7UDLv9S3y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXfiQcAAoJECTWi3JdVIfQ2aoH/Rot20f/VvhU1bvTuwQquw3Z vY5f/urVdJsrnWjl56hhK9gsJYK2+9WjUDZJOYWV8rgn795tyCmrhI1yaIMSdgmo XrgB1XNEN9iSbjrAa3F+20UYOX//J6H4+uaXl5m1VFd19flPmn272J/ZZ5YUQ3sj w4rKyWWIO+QCOIq9zlk6mGQfXgRYNBFJ5HcDdLQ+9sZh+YHL0a/CdWxs77ROZ99z 5angMZPKtxq3gflzn3kHbIo3icHGexFlojiovHXmbH1MoS/9+fKKb+rP9QzRoSPg pnsTbEE7c1cOKetvjMQyL/cqNMqX0PaeW4OP30fs6LCNgo5J9MRVFEo/ZMLqVPo= =uBHB -----END PGP SIGNATURE----- --QLVPfMX7UDLv9S3y--