From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752182AbcGGJoj (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 05:44:39 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:11252 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751439AbcGGJoi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2016 05:44:38 -0400
X-IronPort-AV: E=Sophos;i="5.28,324,1464652800"; 
   d="scan'208";a="371739898"
Date: Thu, 7 Jul 2016 11:44:05 +0200
From: Roger Pau Monne <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf()
 where possible
Message-ID: <20160707094405.mgv6uykxmqsq4fi2@mac>
References: <577E29A902000078000FBF28@prv-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <577E29A902000078000FBF28@prv-mh.provo.novell.com>
User-Agent: Mutt/1.6.0-neo (2016-04-07)
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
>  drivers/block/xen-blkfront.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
> @@ -1825,14 +1825,13 @@ again:
>  		}
>  		kfree(path);
>  	}
> -	err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
> -			    XEN_IO_PROTO_ABI_NATIVE);
> +	err = xenbus_write(xbt, dev->nodename, "protocol",
> +			   XEN_IO_PROTO_ABI_NATIVE);
>  	if (err) {
>  		message = "writing protocol";
>  		goto abort_transaction;
>  	}
> -	err = xenbus_printf(xbt, dev->nodename,
> -			    "feature-persistent", "%u", 1);
> +	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");

AFAICT you forgot to replace xenbus_printf with xenbus_write here.

Roger.