From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933272AbcGGJ77 (ORCPT ); Thu, 7 Jul 2016 05:59:59 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:35978 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbcGGJ7x (ORCPT ); Thu, 7 Jul 2016 05:59:53 -0400 X-AuditID: cbfee68d-f79876d000001436-87-577e27d10d82 Date: Thu, 07 Jul 2016 18:58:41 +0900 From: Andi Shyti To: Mark Brown Cc: Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi Message-id: <20160707095840.GH23620@samsunx.samsung> References: <1467876237-12183-1-git-send-email-andi.shyti@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1467876237-12183-1-git-send-email-andi.shyti@samsung.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWyRsSkUPeiel24wYyDYhaLfzxnspj68Amb xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY7Jo/HiT3eLwm3ZWB06P60s+MXtsWtXJ5rF5Sb1H 35ZVjB6fN8kFsEZx2aSk5mSWpRbp2yVwZcw8+pqpYBVLxe9tC1gaGJcwdzFyckgImEg8Xv+P CcIWk7hwbz0biC0ksIJRom+tAUzNjsU7GbsYuYDiSxklTlyfywrhfGSUaJjZBdbBIqAq8f7n IVYQm01AU6Lp9g+wuIiAssTV73tZQGxmgWVMEq9aQ0FsYYFwiSP7N4LFeYE2vJz/D2roHEaJ RZf3s0EkBCV+TL4H1awlsX7ncSYIW1ri0d8Z7CA2p4C7xOTJl4DiHByiQMvuLguCuPoau0TH OmGI2wQkvk0+xAJSIiEgK7HpANTzkhIHV9xgmcAoNgvJsllIls1CsmwBI/MqRtHUguSC4qT0 IkO94sTc4tK8dL3k/NxNjMAoPP3vWe8OxtsHrA8xCnAwKvHwHuioDRdiTSwrrsw9xGgKdMVE ZinR5HxgrOeVxBsamxlZmJqYGhuZW5opifMqSv0MFhJITyxJzU5NLUgtii8qzUktPsTIxMEp 1cBYMUfcYtb0Xf+7ZL6zPf6nO3+pwqYztQ8itNwfHKm2PJz74MXS3YeuOP6+Nf1EgJ+STkHU +iCZS7P4SzheF/1rNnf3E95s17En4VacUXOJmL4Ix6UcGzkTRo9ewyNyi7cfL3Juql551C3A 7eTn+9M+nZ7B/fKer9kuz3dcX88f4IvJ+iF4rUdMiaU4I9FQi7moOBEAVTPVHr0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t9jAd2L6nXhBh2NghaLfzxnspj68Amb xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY7Jo/HiT3eLwm3ZWB06P60s+MXtsWtXJ5rF5Sb1H 35ZVjB6fN8kFsEY1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5 +AToumXmAN2jpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcyYefQ1U8Eq lorf2xawNDAuYe5i5OSQEDCR2LF4JyOELSZx4d56ti5GLg4hgaWMEieuz2WFcD4ySjTM7GID qWIRUJV4//MQK4jNJqAp0XT7B1hcREBZ4ur3vSwgNrPAMiaJV62hILawQLjEkf0bweK8QNte zv8HNXQOo8Siy/vZIBKCEj8m34Nq1pJYv/M4E4QtLfHo7wx2EJtTwF1i8uRLQHEODlGgZXeX BU1gFJiFpHsWku5ZSLoXMDKvYpRILUguKE5KzzXKSy3XK07MLS7NS9dLzs/dxAiO9mfSOxgP 73I/xCjAwajEw7sgpzZciDWxrLgy9xCjBAezkghvoHJduBBvSmJlVWpRfnxRaU5q8SFGU2CA TGSWEk3OByaivJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1MOpy bfM9wCw/jUtk1l6NhZmBplESPez6LDq8ClflxdwimpT/ntvEb+pnzS7kMb1urVz2a87j4Sc2 apltyGsNk63fb3X7xuQLerNVTmw4sKO6oLK/KtfkonEP9w/2/T7fTpzk3sn2WUHo8DSGRYx8 u/4/OLHgCPeRa1MWqd6faPW6fcZXjkdG2UosxRmJhlrMRcWJAArlA+AMAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > if (sdd->port_conf->clk_from_cmu) { > - /* Configure Clock */ > - /* There is half-multiplier before the SPI */ > clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); sorry, I will re-send it because I should not remove the comments above.... in the future someone might wonder why it's multiplied by 2. That's called auto review and auto-nack :) Andi > - /* Enable Clock */ > - clk_prepare_enable(sdd->src_clk); > } else { > /* Configure Clock */ > val = readl(regs + S3C64XX_SPI_CLK_CFG); > -- > 2.8.1 >