From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbcGGN1u (ORCPT ); Thu, 7 Jul 2016 09:27:50 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:48925 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbcGGN1m (ORCPT ); Thu, 7 Jul 2016 09:27:42 -0400 X-AuditID: cbfee68f-f79476d000001429-52-577e58cac1f7 Date: Thu, 07 Jul 2016 22:27:38 +0900 From: Andi Shyti To: Krzysztof Kozlowski Cc: Chanwoo Choi , Jaehoon Chung , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks Message-id: <20160707132738.GI23620@samsunx.samsung> References: <1467893637-12573-1-git-send-email-andi.shyti@samsung.com> <1467893637-12573-2-git-send-email-andi.shyti@samsung.com> <577E4F1C.8070004@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <577E4F1C.8070004@samsung.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsWyRsSkUPdURF24wfX3OhaLfzxnsrj+5Tmr xY1fbawWr18YWvQ/fs1ssenxNVaLjz33WC0u75rDZjHj/D4mi4unXC0Ov2lntfhxppvFYtWu P4wOvB7vb7Sye1zu62XyuL7kE7PHzll32T02repk89i8pN6jb8sqRo/Pm+QCOKK4bFJSczLL Uov07RK4Mr4ufsdScIetYs7ar+wNjItZuxg5OCQETCSWdXN1MXICmWISF+6tZ+ti5OIQEljB KHH04A1GiISJxN+OrcwQiaWMEh37/zBCOB8ZJe6cX8EKUsUioCrReH43O4jNJqAp0XT7BxuI LSJgKHFw93YmkAZmgSPMEisXdzCDJIQFoiS2PXvEAmLzAq1YN6+dBWLqD0aJx29us0MkBCV+ TL4HVsQsoCWxfudxJghbWuLR3xlgNZwC2hLTP55gAflHVEBZ4u6yIJA5EgITOSQW3j/MBHGd gMS3yYdYIH6Wldh0gBniNUmJgytusExgFJuFZNssJNtmIdm2gJF5FaNoakFyQXFSepGxXnFi bnFpXrpecn7uJkZgNJ/+96x/B+PdA9aHGAU4GJV4eDdU1YYLsSaWFVfmHmI0BbpiIrOUaHI+ MGXklcQbGpsZWZiamBobmVuaKYnzLpT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB0Uzh oe32tJPPtB/eOfDY48l0JYEZt7+fuf1kssYVk6DV8YEzuF+o79jD/s/R6UAuy0+1Hc/UZs5Y 8ZD/yuJEc6OJTHdeMuT8CPgY/Md7/omcyp0/jy2NqXocEHkwXmbyx5cu6zuCEqcozXav+qyq fcjg3ULPq/f+VleKXH8pneR9sNRX6ahFSoESS3FGoqEWc1FxIgCXZ9oK4QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd1TEXXhBm/a1C0W/3jOZHH9y3NW ixu/2lgtXr8wtOh//JrZYtPja6wWH3vusVpc3jWHzWLG+X1MFhdPuVocftPOavHjTDeLxapd fxgdeD3e32hl97jc18vkcX3JJ2aPnbPusntsWtXJ5rF5Sb1H35ZVjB6fN8kFcEQ1MNpkpCam pBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAF2spFCWmFMKFApI LC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcz4uvgdS8Edtoo5a7+yNzAuZu1i5OSQEDCR +NuxlRnCFpO4cG89WxcjF4eQwFJGiY79fxghnI+MEnfOrwDrYBFQlWg8v5sdxGYT0JRouv2D DcQWETCUOLh7OxNIA7PAEWaJlYs7wMYKC0RJbHv2iAXE5gVat25eOwvE1B+MEo/f3GaHSAhK /Jh8D6yIWUBLYv3O40wQtrTEo78zwGo4BbQlpn88AVTDwSEqoCxxd1nQBEaBWUi6ZyHpnoWk ewEj8ypGidSC5ILipPRcw7zUcr3ixNzi0rx0veT83E2M4JTxTGoH48Fd7ocYBTgYlXh4F+TU hguxJpYVV+YeYpTgYFYS4ZUIrwsX4k1JrKxKLcqPLyrNSS0+xGgKDJGJzFKiyfnAdJZXEm9o bGJmZGlkbmhhZGyuJM77+P+6MCGB9MSS1OzU1ILUIpg+Jg5OqQZGrraPL9ye8olpSnJEdwtt 49m2/4vo24uR/F8Pa/Rsv7Hj78+dhkZ3526Q1Hp+8lFrH8cm/9mqCSzXXt8rOSo4n+U22yTx y84ffgRrP9Z9p9DwlvGVQaFw4r3bSRN4mZ/IxCx3mX+1f1+q66IXnmufei5v5J+xzX9769z3 D2Z7V+3e6FSTeMl4ihJLcUaioRZzUXEiACEWuFEvAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, > > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. > > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, > > which enables the clock line during boot time. > > I don't agree. Both flags should be avoided. Clk is critical does not > solve the problem. It is just a better workaround for lack of proper > clock consumers. > > The IOCLK is not a critical clock. It can be disabled (e.g. when SoC is > used on a board without any SPI device connected). As we discussed offline there is no driver which is requesting this clock. We cannot ask to the spi driver to handle three clocks because the exynos5433 has its own peculiarities. If we want this on the spi driver's side, we need to add a new compatible and check it everytime. To me it looks uglier than just keep it alive. Thanks, Andi