From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753097AbcGGPiN (ORCPT ); Thu, 7 Jul 2016 11:38:13 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31497 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbcGGPiE (ORCPT ); Thu, 7 Jul 2016 11:38:04 -0400 Date: Thu, 7 Jul 2016 11:37:51 -0400 From: Konrad Rzeszutek Wilk To: Andrew Cooper Cc: Roger Pau Monne , Jan Beulich , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" Message-ID: <20160707153750.GB11480@localhost.localdomain> References: <577E233202000078000FBE11@prv-mh.provo.novell.com> <20160707094535.wsgrxlnib5ajcsdc@mac> <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: > On 07/07/16 10:45, Roger Pau Monne wrote: > > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > >> The functions such get passed to have been taking pointers to const > >> since at least 2.6.16. > >> > >> Signed-off-by: Jan Beulich > > Acked-by: Roger Pau Monné > > > > Although the wording in the commit message looks weird to me, but I'm not a > > native speaker anyway. > > As a native speaker, I can't parse it either. > > I think s/such/these/ is needed. The functions such as these have been taking pointers to const since at least 2.6.16. ? > > ~Andrew > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel