From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbcGGP4p (ORCPT ); Thu, 7 Jul 2016 11:56:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:50022 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbcGGP4g (ORCPT ); Thu, 7 Jul 2016 11:56:36 -0400 Date: Thu, 7 Jul 2016 17:56:33 +0200 From: Petr Mladek To: Jessica Yu Cc: Josh Poimboeuf , Miroslav Benes , Jiri Kosina , Chris J Arges , Eugene Shatokhin , live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Fix issue with alternatives/paravirt patches Message-ID: <20160707155633.GC3556@pathway.suse.cz> References: <1467772500-26092-1-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467772500-26092-1-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2016-07-05 22:34:58, Jessica Yu wrote: > Hi, > > A few months ago, Chris Arges reported a bug involving alternatives/paravirt > patching that was discussed here [1] and here [2]. To briefly summarize the > bug, patch modules that contained .altinstructions or .parainstructions > sections would break because these alternative/paravirt patches would be > applied first by the module loader (see x86 module_finalize()), then > livepatch would later clobber these patches when applying per-object > relocations. This lead to crashes and unpredictable behavior. > > One conclusion we reached from our last discussion was that we will > need to introduce some arch-specific code to address this problem. > This patchset presents a possible fix for the bug by adding a new > arch-specific arch_klp_init_object_loaded() function that by default > does nothing but can be overridden by different arches. > > To fix this issue for x86, since we can access a patch module's Elf > sections through mod->klp_info, we can simply delay the calls to > apply_paravirt() and apply_alternatives() to arch_klp_init_object_loaded(), > which is called after relocations have been written for an object. > In addition, for patch modules, .parainstructions and .altinstructions are > prefixed by ".klp.arch.${objname}" so that the module loader ignores them > and livepatch can apply them manually. The solution looks correct to me. The fun will be how to generate the sections. If I get this correctly, it is not enough to rename the existing ones. Instead, we need to split .parainstructions and .altinstructions sections into per-object ones. I wonder if there is a plan for this. Especially I am interested into the patches created from sources ;-) I wonder if we could add a tag somewhere and improve the build infrastructure. Best Regards, Petr