From: David Miller <davem@davemloft.net>
To: mw@semihalf.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com,
andrew@lunn.ch, jason@lakedaemon.net,
thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com, nadavh@marvell.com,
alior@marvell.com, nitroshift@yahoo.com, jaz@semihalf.com,
dima@marvell.com, stable@vger.kernel.org
Subject: Re: [PATCH net] net: mvneta: set real interrupt per packet for tx_done
Date: Fri, 08 Jul 2016 23:45:18 -0400 (EDT) [thread overview]
Message-ID: <20160708.234518.1265002080156810187.davem@davemloft.net> (raw)
In-Reply-To: <1467771538-31811-1-git-send-email-mw@semihalf.com>
From: Marcin Wojtas <mw@semihalf.com>
Date: Wed, 6 Jul 2016 04:18:58 +0200
> From: Dmitri Epshtein <dima@marvell.com>
>
> Commit aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay") intended to
> set coalescing threshold to a value guaranteeing interrupt generation
> per each sent packet, so that buffers can be released with no delay.
>
> In fact setting threshold to '1' was wrong, because it causes interrupt
> every two packets. According to the documentation a reason behind it is
> following - interrupt occurs once sent buffers counter reaches a value,
> which is higher than one specified in MVNETA_TXQ_SIZE_REG(q). This
> behavior was confirmed during tests. Also when testing the SoC working
> as a NAS device, better performance was observed with int-per-packet,
> as it strongly depends on the fact that all transmitted packets are
> released immediately.
>
> This commit enables NETA controller work in interrupt per sent packet mode
> by setting coalescing threshold to 0.
>
> Signed-off-by: Dmitri Epshtein <dima@marvell.com>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v3.10+
> Fixes aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay")
Applied, thanks.
prev parent reply other threads:[~2016-07-09 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 2:18 Marcin Wojtas
2016-07-06 5:04 ` Willy Tarreau
2016-07-09 3:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708.234518.1265002080156810187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=dima@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nitroshift@yahoo.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®