From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755448AbcGHN4s (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 09:56:48 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:47931 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754911AbcGHN4k convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 09:56:40 -0400
Date: Fri, 8 Jul 2016 09:55:31 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
        Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct
 attribute_group"
Message-ID: <20160708135531.GB22329@char.us.oracle.com>
References: <577E233202000078000FBE11@prv-mh.provo.novell.com>
 <20160707094535.wsgrxlnib5ajcsdc@mac>
 <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com>
 <20160707153750.GB11480@localhost.localdomain>
 <577E97F602000078000FC546@prv-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <577E97F602000078000FC546@prv-mh.provo.novell.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Transfer-Encoding: 8BIT
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote:
> >>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> >> On 07/07/16 10:45, Roger Pau Monne wrote:
> >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> >> The functions such get passed to have been taking pointers to const
> >> >> since at least 2.6.16.
> >> >>
> >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >> >
> >> > Although the wording in the commit message looks weird to me, but I'm not a 
> > 
> >> > native speaker anyway.
> >> 
> >> As a native speaker, I can't parse it either.
> >> 
> >> I think s/such/these/ is needed.
> > 
> > The functions such as these have been taking pointers to const
> > since at least 2.6.16. 
> 
> I had taken Andrew's suggestion literally and changed it to "The
> functions these get passed to have been taking pointers to const
> since at least 2.6.16" for a possible (if needed) resubmission.

No need to resubmit. I will use Andrew's suggestion.
> 
> Jan