From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755475AbcGHOK1 (ORCPT ); Fri, 8 Jul 2016 10:10:27 -0400 Received: from mail.skyhub.de ([78.46.96.112]:53673 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754746AbcGHOKT (ORCPT ); Fri, 8 Jul 2016 10:10:19 -0400 Date: Fri, 8 Jul 2016 16:10:16 +0200 From: Borislav Petkov To: Ingo Molnar Cc: X86 ML , LKML Subject: [PATCH v1.1] x86/asm/entry: Make thunk's restore a local label Message-ID: <20160708141016.GH3808@pd.tnic> References: <1466682594-23019-1-git-send-email-bp@alien8.de> <20160708133851.GA6864@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160708133851.GA6864@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 03:38:51PM +0200, Ingo Molnar wrote: > Btw., could we make it .L_restore to make it more readable - or does the > underscore confuse tooling? Nah, builds fine too. --- From: Borislav Petkov Date: Fri, 8 Jul 2016 16:01:48 +0200 Subject: [PATCH v1.1] x86/asm/entry: Make thunk's restore a local label No need to have it appear in objdump output. No functionality change. Signed-off-by: Borislav Petkov --- arch/x86/entry/thunk_64.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S index 027aec4a74df..627ecbcb2e62 100644 --- a/arch/x86/entry/thunk_64.S +++ b/arch/x86/entry/thunk_64.S @@ -33,7 +33,7 @@ .endif call \func - jmp restore + jmp .L_restore _ASM_NOKPROBE(\name) .endm @@ -54,7 +54,7 @@ #if defined(CONFIG_TRACE_IRQFLAGS) \ || defined(CONFIG_DEBUG_LOCK_ALLOC) \ || defined(CONFIG_PREEMPT) -restore: +.L_restore: popq %r11 popq %r10 popq %r9 @@ -66,5 +66,5 @@ restore: popq %rdi popq %rbp ret - _ASM_NOKPROBE(restore) + _ASM_NOKPROBE(.L_restore) #endif -- 2.7.3 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.