From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbcGHPNj (ORCPT ); Fri, 8 Jul 2016 11:13:39 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25053 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbcGHPNe (ORCPT ); Fri, 8 Jul 2016 11:13:34 -0400 Date: Fri, 8 Jul 2016 11:12:20 -0400 From: Konrad Rzeszutek Wilk To: Jan Beulich Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, Juergen Gross , linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Message-ID: <20160708151220.GB7213@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> <20160708141737.GG22329@char.us.oracle.com> <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 09:06:36AM -0600, Jan Beulich wrote: > >>> On 08.07.16 at 16:17, wrote: > > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: > >> For single items being collected this should be preferred as being more > >> typesafe (as the compiler can check format string and to-be-written-to > >> variable match) and more efficient (requiring one less parameter to be > >> passed). > >> > >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather() > >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() > >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() > >> > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Avoid commit messages to continue from subjects. Group into a series. > > > > To confuse this, Roger and I are the block sub-maintainers, which > > when we are happy, I send to Jens, while the rest go through Boris,David, > > and Juergen. > > Which is why originally I had sent all of these separately. Yet David > was pretty unhappy about that. Aye! I am not critizing, just saying that this is getting complicated and you are in the unfortunate situation to have to deal with this - so want to apoligize for you having to go through this gauntlet.