From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756249AbcGHVcq (ORCPT ); Fri, 8 Jul 2016 17:32:46 -0400 Received: from smtprelay0180.hostedemail.com ([216.40.44.180]:57827 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754870AbcGHVck (ORCPT ); Fri, 8 Jul 2016 17:32:40 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:800:960:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2525:2553:2560:2563:2682:2685:2859:2910:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:6117:6261:7875:7903:9025:9707:10004:10400:10848:10967:11026:11232:11658:11854:11914:12043:12296:12517:12519:12555:12663:12698:12737:12740:13069:13255:13311:13357:13439:14181:14659:14721:21063:21080:30054:30056:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: trade75_5144824d88516 X-Filterd-Recvd-Size: 2162 Date: Fri, 8 Jul 2016 17:32:37 -0400 From: Steven Rostedt To: Laura Abbott Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] ftrace/scripts: Work around for addition of metag magic but not relocations Message-ID: <20160708173237.6a24ef21@gandalf.local.home> In-Reply-To: <1468005530-14757-1-git-send-email-labbott@redhat.com> References: <1468005530-14757-1-git-send-email-labbott@redhat.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jul 2016 12:18:50 -0700 Laura Abbott wrote: > glibc recently did a sync up (94e73c95d9b5 "elf.h: Sync with the gabi > webpage") that added a #define for EM_METAG but did not add relocations > > This triggers build errors: > > scripts/recordmcount.c: In function 'do_file': > scripts/recordmcount.c:466:28: error: 'R_METAG_ADDR32' undeclared (first use in this function) > case EM_METAG: reltype = R_METAG_ADDR32; > ^~~~~~~~~~~~~~ > scripts/recordmcount.c:466:28: note: each undeclared identifier is reported only once for each function it appears in > scripts/recordmcount.c:468:20: error: 'R_METAG_NONE' undeclared (first use in this function) > rel_type_nop = R_METAG_NONE; > ^~~~~~~~~~~~ > > Work around this change with some more #ifdefery for the relocations. Looks fine to me. I'll pull it in, and this probably should go stable too. -- Steve > > Signed-off-by: Laura Abbott > --- > I hit this while testing with a newer glibc. I'm not sure what the policy is > about glibc, so this might just serve as an FYI for anyone else who > is working on the bleeding edge. > > Fedora bug is at https://bugzilla.redhat.com/show_bug.cgi?id=1354034 for the > curious. > ---