From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756360AbcGHVIj (ORCPT ); Fri, 8 Jul 2016 17:08:39 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36519 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755559AbcGHVI3 (ORCPT ); Fri, 8 Jul 2016 17:08:29 -0400 Date: Fri, 8 Jul 2016 14:08:24 -0700 From: Dmitry Torokhov To: Martin Kepplinger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, kernel-testers@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Message-ID: <20160708210824.GE28589@dtor-ws> References: <1465903215-2351-1-git-send-email-martink@posteo.de> <20160623171835.GE32561@dtor-ws> <246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: > Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > > Hi Martin, > > > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > >> static int pegasus_reset_resume(struct usb_interface *intf) > >> { > >> + struct pegasus *pegasus = usb_get_intfdata(intf); > >> + > >> + if (pegasus->dev->users) > >> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE); > >> + > >> return pegasus_resume(intf); > > > > Hmm, we need to take input mutex when using pegasus->dev->users, how > > about the version below instead? > > > > Thanks. > > > > Sorry for the delay, give me a few more days to test and confirm this or > come up with a final patch. Martin, did you have time to try out this version of the patch? Thanks! -- Dmitry