From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbcGIEBe (ORCPT ); Sat, 9 Jul 2016 00:01:34 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbcGIEBY (ORCPT ); Sat, 9 Jul 2016 00:01:24 -0400 Date: Sat, 09 Jul 2016 00:00:28 -0400 (EDT) Message-Id: <20160709.000028.885177477710080482.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next] net: dsa: initialize the routing table From: David Miller In-Reply-To: <20160707000354.18217-1-vivien.didelot@savoirfairelinux.com> References: <20160707000354.18217-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Jul 2016 21:00:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Wed, 6 Jul 2016 20:03:54 -0400 > The routing table of every switch in a tree is currently initialized to > all zeros. This is an issue since 0 is a valid port number. > > Add a DSA_RTABLE_NONE=-1 constant to initialize the signed values of the > routing table pointing to other switches. > > This fixes the device mapping of the mv88e6xxx driver where the port > pointing to the switch itself and to non-existent switches was wrongly > configured to be 0. It is now set to the expected 0xf value. > > Signed-off-by: Vivien Didelot Applied.