From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbcGKT5g (ORCPT ); Mon, 11 Jul 2016 15:57:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59872 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbcGKT5e (ORCPT ); Mon, 11 Jul 2016 15:57:34 -0400 Date: Mon, 11 Jul 2016 12:57:33 -0700 (PDT) Message-Id: <20160711.125733.1619512909014032205.davem@davemloft.net> To: tremyfr@gmail.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" From: David Miller In-Reply-To: <1468018487-8102-1-git-send-email-tremyfr@gmail.com> References: <1468018487-8102-1-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jul 2016 12:57:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Reynes Date: Sat, 9 Jul 2016 00:54:47 +0200 > This reverts commit 4386f5662e63 ("net: ethernet: bcmgenet: use > phy_ethtool_{get|set}_link_ksettings") > > This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings > don't check if the device is running, but the driver bcmgenet need this > check. > > The function {get|set}_settings need to access the mdio bus, and this > bus may only be used when the device is running. Otherwise, the clock > is disable and a mdio access will fail. > > Signed-off-by: Philippe Reynes Applied.