From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758961AbcGKOdr (ORCPT ); Mon, 11 Jul 2016 10:33:47 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34599 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758293AbcGKOdq (ORCPT ); Mon, 11 Jul 2016 10:33:46 -0400 Date: Mon, 11 Jul 2016 16:33:42 +0200 From: Michal Hocko To: Rik van Riel Cc: Janani Ravichandran , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov@virtuozzo.com, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, bywxiaobai@163.com Subject: Re: [PATCH 1/3] Add a new field to struct shrinker Message-ID: <20160711143342.GN1811@dhcp22.suse.cz> References: <85a9712f3853db5d9bc14810b287c23776235f01.1468051281.git.janani.rvchndrn@gmail.com> <20160711063730.GA5284@dhcp22.suse.cz> <1468246371.13253.63.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468246371.13253.63.camel@surriel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 11-07-16 10:12:51, Rik van Riel wrote: > On Mon, 2016-07-11 at 08:37 +0200, Michal Hocko wrote: > > On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > > > Struct shrinker does not have a field to uniquely identify the > > > shrinkers > > > it represents. It would be helpful to have a new field to hold > > > names of > > > shrinkers. This information would be useful while analyzing their > > > behavior using tracepoints. > > > > This will however increase the vmlinux size even when no tracing is > > enabled. Why cannot we simply print the name of the shrinker > > callbacks? > > What mechanism do you have in mind for obtaining the name, > Michal? Not sure whether tracing infrastructure allows printk like %ps. If not then it doesn't sound too hard to add. -- Michal Hocko SUSE Labs