From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030836AbcGKO7D (ORCPT ); Mon, 11 Jul 2016 10:59:03 -0400 Received: from mail-yw0-f180.google.com ([209.85.161.180]:36861 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232AbcGKO7A (ORCPT ); Mon, 11 Jul 2016 10:59:00 -0400 Date: Mon, 11 Jul 2016 09:58:54 -0500 From: Rob Herring To: William Wu Cc: gregkh@linuxfoundation.org, balbi@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, briannorris@google.com, dianders@google.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, frank.wang@rock-chips.com, eddie.cai@rock-chips.com, John.Youn@synopsys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, devicetree@vger.kernel.org Subject: Re: [PATCH v6 3/5] usb: dwc3: add phyif_utmi_quirk Message-ID: <20160711145854.GB16636@rob-hp-laptop> References: <1467860066-15142-1-git-send-email-william.wu@rock-chips.com> <1467860066-15142-4-git-send-email-william.wu@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467860066-15142-4-git-send-email-william.wu@rock-chips.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 10:54:24AM +0800, William Wu wrote: > Add a quirk to configure the core to support the > UTMI+ PHY with an 8- or 16-bit interface. UTMI+ PHY > interface is hardware property, and it's platform > dependent. Normall, the PHYIf can be configured s/Normall/Normally/ s/PHYIf/PHYIF/ > during coreconsultant. But for some specific usb s/usb/USB/ > cores(e.g. rk3399 soc dwc3), the default PHYIf > configuration value is fault, so we need to > reconfigure it by software. > > And refer to the dwc3 databook, the GUSB2PHYCFG.USBTRDTIM s/dwc3/DWC3/ > must be set to the corresponding value according to > the UTMI+ PHY interface. And wrap your lines at 70-74 characters. Rob