From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbcGKVMn (ORCPT ); Mon, 11 Jul 2016 17:12:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37724 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcGKVMm (ORCPT ); Mon, 11 Jul 2016 17:12:42 -0400 Date: Mon, 11 Jul 2016 22:12:35 +0100 From: Mark Brown To: John Crispin Cc: Liam Girdwood , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chen Zhong Message-ID: <20160711211235.GB9976@sirena.org.uk> References: <1468240179-7558-1-git-send-email-john@phrozen.org> <1468240179-7558-2-git-send-email-john@phrozen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CdrF4e02JqNVZeln" Content-Disposition: inline In-Reply-To: <1468240179-7558-2-git-send-email-john@phrozen.org> X-Cookie: On the eighth day, God created FORTRAN. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V8 2/2] regulator: mt6323: Add support for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CdrF4e02JqNVZeln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 11, 2016 at 02:29:39PM +0200, John Crispin wrote: > +static const struct of_device_id mt6323_of_match[] = { > + { .compatible = "mediatek,mt6323-regulator", }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, mt6323_of_match); This may have been answered last time but I don't remember - why is there a compatible string for this device in the DT? Surely we already know that the regulators for the mt6323 are present by virtue of the fact that we know that the core mt6323 is present in the system? Indeed, looking at the now merged MFD code it appears that this is in fact the case so we could just not have a compatible and perhaps this was just an oversight. This is good because it means we're not encoding the specific way Linux instantiates devices into the DT. Otherwise this does look good. --CdrF4e02JqNVZeln Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXhAvCAAoJECTWi3JdVIfQuokH/RuZOTGynp7Z4mnBvT8SpybP ZSS2so9V40HJ/K1q5w17d6wuZiIAYQwOV26bgcGSfAbC223W9BhBwABF9bq9nQZf k6aJfRCs3KvWxJ8vQ6o4YcpAc4MhWUPbbxmmm6/B7EOzu+l5rPCDmxxc+10d61OF bySzJRuy1NYJan1AN6Up5XFQJYY7fBewauF+lZTGfpCaGXEikwnNwrmzdMbZF3I8 G53jj4Qtsi2jg5NCVm0bWaTh8dpoKmowqiIl6jlRMj81fbx6KorCh18U6z5UxcXR wj8A9sKydkjHs6dSk+Qw7y7KNfeVH7YnugRgJkAi9ysWO8sG3jebDFduqU7Qoao= =SdQg -----END PGP SIGNATURE----- --CdrF4e02JqNVZeln--