From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbcGKVqb (ORCPT ); Mon, 11 Jul 2016 17:46:31 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60654 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbcGKVq3 (ORCPT ); Mon, 11 Jul 2016 17:46:29 -0400 From: Arnd Bergmann To: Jiri Kosina Cc: Arnd Bergmann , Benjamin Tissoires , Heiner Kallweit , Yusuke Fujimaki , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Date: Mon, 11 Jul 2016 23:49:20 +0200 Message-Id: <20160711214954.2668262-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:9MkoOTYdtevkFnTuhXV6sqYXNMaSKxC6NKAAXgIMQpdZyDbQA/5 zvTnCF0VfQvJA0ksQ84UVuQwrq3IUayJlb2OlKiDf/T4tED8KJ+X3c6G9DX4z/h5iB3sU/X 3nWEd/hTo5kfRNqIFrixniWsagsiGUAYIOGOZfueV1TLlNY7KL8asLi60/SkI1jk+skk1NE D23CaofJ1vKtsywCrMEaA== X-UI-Out-Filterresults: notjunk:1;V01:K0:7U47FVwOYGM=:TEucoGHHMPlNHRCiwzefjJ zEmFnoHRKeQ5cNqUMbn8PAy/HS/yNVnqxIPdry5YQRd9nRHFJvzw1T+Xh+XYmPFNHtTSAFXBm 3HLtpNKwaOiOnoVNYxqvDcAsu3EeqTpnUyv/vUgnj+b0Qf+YPA/pqB2vPf82MG9sfth2AnmYy rbSWdD6eUQuhxoA4Ld+rBWnJlWNKXTP2HRKm2gCybLmFB2wUhJjrZjkzgymQk/gaiOLPrQr3K kbZKkF/6Y+svK6+THDpKD0w+zGi3xCDzOViQGXeom/gVVu2DlWg/+kWF/phFnXlih9V5ibkOj EuNJ91/ggYavWBILmvz1plBZeDnMzxv0aEIiMw7lqjUn9xZyR+059gyu0IQ2QFpCqP+HAZOsv VIBHC3CMy8pJeGBiUVV5Sfrl0AoidVQL2Au3TM1l9WrgcoeXWh1PkCj1G89VDo+wUoO/gzKC1 KMduBNiN5zfeZgL6uoVSnDqNYZt9u1067jLt55g0o5dT6S/VPh+zCOckdRRHzC8EzCdf2eaL/ 43xnYA1v3zUwYf8LAjSyxjMo02UCdDzsOuY7TucFin3wP2zrpZ2Nm3vAB1FZBlJ5seif9kkPo 3Mct8V7QBigKD9OHQULmC8Fhzs2Zp+4P0mskRB9cGTU19sc92ii9bff8kgeJa5+0phv4S/UVp aX+2rjIobmmvjZSmFCD2lOoxr/KlxiVTpoU5fhs5c3Wc+IjgvM9qAOaSdgmzx9hgz77Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent commit added barry support to this driver, but that causes a link failure when CONFIG_POWER_SUPPLY is not set: drivers/hid/built-in.o: In function `hidpp_battery_get_property': :(.text+0x1a834): undefined reference to `power_supply_get_drvdata' drivers/hid/built-in.o: In function `hidpp_raw_event': :(.text+0x1b10c): undefined reference to `power_supply_changed' drivers/hid/built-in.o: In function `hidpp_connect_event': :(.text+0x1bd88): undefined reference to `devm_power_supply_register' :(.text+0x1be30): undefined reference to `power_supply_powers' This adds a dependency, identically to the other HID drivers that need this. Signed-off-by: Arnd Bergmann Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices") --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 78ac4811bd3c..4c6b59c9fa15 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ config HID_LOGITECH_HIDPP tristate "Logitech HID++ devices support" depends on HID_LOGITECH + select POWER_SUPPLY ---help--- Support for Logitech devices relyingon the HID++ Logitech specification -- 2.9.0