From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbcGLHOG (ORCPT ); Tue, 12 Jul 2016 03:14:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:33355 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752267AbcGLHOD (ORCPT ); Tue, 12 Jul 2016 03:14:03 -0400 Date: Tue, 12 Jul 2016 09:14:00 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Javier Martinez Canillas , Sudeep Holla , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Krzysztof Kozlowski , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: isl12057: remove unused variables Message-ID: <20160712071400.GT22202@piout.net> References: <20160711214340.2574022-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711214340.2574022-1-arnd@arndb.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 11/07/2016 at 23:42:57 +0200, Arnd Bergmann wrote : > A cleanup patch introduced a harmless warning about now unused local variables: > > drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm': > drivers/rtc/rtc-isl12057.c:249:26: error: unused variable 'alarm_secs' [-Werror=unused-variable] > unsigned long rtc_secs, alarm_secs; > ^~~~~~~~~~ > drivers/rtc/rtc-isl12057.c:249:16: error: unused variable 'rtc_secs' [-Werror=unused-variable] > unsigned long rtc_secs, alarm_secs; > ^~~~~~~~ > drivers/rtc/rtc-isl12057.c:248:18: error: unused variable 'rtc_tm' [-Werror=unused-variable] > struct rtc_time rtc_tm, *alarm_tm = &alarm->time; > ^~~~~~ > > This removes the variables to shut up those warnings. > > Signed-off-by: Arnd Bergmann > Fixes: 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm") I actually fixed it up in the patch yesterday. > --- > drivers/rtc/rtc-isl12057.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c > index e0245fc6205e..0e7f0f52bfe4 100644 > --- a/drivers/rtc/rtc-isl12057.c > +++ b/drivers/rtc/rtc-isl12057.c > @@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable) > static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) > { > struct isl12057_rtc_data *data = dev_get_drvdata(dev); > - struct rtc_time rtc_tm, *alarm_tm = &alarm->time; > - unsigned long rtc_secs, alarm_secs; > + struct rtc_time *alarm_tm = &alarm->time; > u8 regs[ISL12057_A1_SEC_LEN]; > unsigned int ir; > int ret; > -- > 2.9.0 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com