From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754185AbcGLKIZ (ORCPT ); Tue, 12 Jul 2016 06:08:25 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34314 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448AbcGLKIW (ORCPT ); Tue, 12 Jul 2016 06:08:22 -0400 Date: Tue, 12 Jul 2016 12:08:17 +0200 From: Daniel Vetter To: Chris Wilson , Steven Newbury , intel-gfx , linux-kernel , dri-devel , James Bottomley , Rodrigo Vivi Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Message-ID: <20160712100817.GV23520@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , Steven Newbury , intel-gfx , linux-kernel , dri-devel , James Bottomley , Rodrigo Vivi References: <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <1466686369.6831.1.camel@snewbury.org.uk> <87r3bohxh6.fsf@intel.com> <1466687652.6831.8.camel@snewbury.org.uk> <20160624105930.GA27113@nuc-i3427.alporthouse.com> <1466768897.1924.1.camel@snewbury.org.uk> <20160624124206.GB7856@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160624124206.GB7856@nuc-i3427.alporthouse.com> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 01:42:06PM +0100, Chris Wilson wrote: > On Fri, Jun 24, 2016 at 12:48:17PM +0100, Steven Newbury wrote: > > On Fri, 2016-06-24 at 11:59 +0100, Chris Wilson wrote: > > > On Thu, Jun 23, 2016 at 02:14:12PM +0100, Steven Newbury wrote: > > > > On Thu, 2016-06-23 at 15:59 +0300, Jani Nikula wrote: > > > > > On Thu, 23 Jun 2016, Steven Newbury > > > > > wrote: > > > > > > I'm seeing this on my IvyBridge.  I'll try reverting the commit > > > > > > here > > > > > > too, to see if it's the same issue. > > > > > > > > > > IvyBridge doesn't have low vswing for eDP. If reverting helps, > > > > > it's a > > > > > different failure mode. > > > > > > > > > It must be something else then.  Actually, in my case linus/master > > > > is > > > > okay.  I saw the subject and though it must be the same issue.  I'm > > > > seeing it with drm-intel nightly/next branches.  Shall I try to > > > > bisect > > > > it?  Symptoms are similar, although I would describe it more like > > > > flashes of a different buffer across parts of the screen. > > > > > > Try reverting ee042aa40b66d18d465206845b0752c6a617ba3f instead. > > > -Chris > > > > > > > Yes, thanks, that "fixed" it.  So atomic commits not working properly > > on IVB? > > Not yet it seems. Something seems to be off in the timing, but has so > far eluded capture. Fyi we reverted this for now to fix things up: commit 527b6abe5fd2d24fba69e9564a2d608e1796ca8d Author: Chris Wilson Date: Fri Jun 24 13:44:03 2016 +0100 Revert "drm/i915: Use atomic commits for legacy page_flips" Kudos to Chris for handling this in my absence. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch