From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753698AbcGLML3 (ORCPT ); Tue, 12 Jul 2016 08:11:29 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33618 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbcGLML1 (ORCPT ); Tue, 12 Jul 2016 08:11:27 -0400 Date: Tue, 12 Jul 2016 14:11:23 +0200 From: Daniel Vetter To: Alexey Khoroshilov Cc: David Airlie , ldv-project@linuxtesting.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init() Message-ID: <20160712121123.GO23520@phenom.ffwll.local> Mail-Followup-To: Alexey Khoroshilov , David Airlie , ldv-project@linuxtesting.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1467237135-13075-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467237135-13075-1-git-send-email-khoroshilov@ispras.ru> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 12:52:15AM +0300, Alexey Khoroshilov wrote: > If class_create() fails, there is no need for class_destroy(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied to drm-misc, thanks for the patch. Out of curiosity, how exactly did you spot this bug? -Daniel > --- > drivers/gpu/drm/drm_dp_aux_dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c > index 3334baacf43d..734f86a345f6 100644 > --- a/drivers/gpu/drm/drm_dp_aux_dev.c > +++ b/drivers/gpu/drm/drm_dp_aux_dev.c > @@ -355,8 +355,7 @@ int drm_dp_aux_dev_init(void) > > drm_dp_aux_dev_class = class_create(THIS_MODULE, "drm_dp_aux_dev"); > if (IS_ERR(drm_dp_aux_dev_class)) { > - res = PTR_ERR(drm_dp_aux_dev_class); > - goto out; > + return PTR_ERR(drm_dp_aux_dev_class); > } > drm_dp_aux_dev_class->dev_groups = drm_dp_aux_groups; > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch